Re: [PATCH] kvm: s390: pv: Mark mm as protected after the set secure parameters and improve cleanup

Cornelia Huck
2020-11-10T11:31:17Z

On Fri, 30 Oct 2020 10:01:41 -0400
Janosch Frank <frankja@linux.ibm.com> wrote:

> We can only have protected guest pages after a successful set secure
> parameters call as only then the UV allows imports and unpacks.
>
> By moving the test we can now also check for it in s390_reset_acc()
> and do an early return if it is 0.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> arch/s390/kvm/kvm-s390.c | 2 +-
> arch/s390/kvm/pv.c | 3 ++-
> arch/s390/mm/gmap.c | 2 ++
> 3 files changed, 5 insertions(+), 2 deletions(-)

Seems reasonable to me. I assume it has been given some coverage by now?

Reviewed-by: Cornelia Huck <cohuck@redhat.com>