From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88EC0C05027 for ; Wed, 8 Feb 2023 14:37:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231157AbjBHOhm convert rfc822-to-8bit (ORCPT ); Wed, 8 Feb 2023 09:37:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230433AbjBHOhm (ORCPT ); Wed, 8 Feb 2023 09:37:42 -0500 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13DC919F15 for ; Wed, 8 Feb 2023 06:37:36 -0800 (PST) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-285-CCJm7qh4OPWJR4mgPmXp4w-1; Wed, 08 Feb 2023 14:37:33 +0000 X-MC-Unique: CCJm7qh4OPWJR4mgPmXp4w-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.45; Wed, 8 Feb 2023 14:37:32 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.045; Wed, 8 Feb 2023 14:37:32 +0000 From: David Laight To: 'Simon Horman' , Alexandra Winter CC: David Miller , Jakub Kicinski , "netdev@vger.kernel.org" , "linux-s390@vger.kernel.org" , Heiko Carstens , Thorsten Winkler , Jules Irenge Subject: RE: [PATCH net-next 4/4] s390/qeth: Convert sprintf/snprintf to scnprintf Thread-Topic: [PATCH net-next 4/4] s390/qeth: Convert sprintf/snprintf to scnprintf Thread-Index: AQHZOwraK1QTWCBVLECBV6pybcO3eq7FHqew Date: Wed, 8 Feb 2023 14:37:32 +0000 Message-ID: <63c6825fc2c94ad19ac7de93a6f151f6@AcuMS.aculab.com> References: <20230206172754.980062-1-wintera@linux.ibm.com> <20230206172754.980062-5-wintera@linux.ibm.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org From: Simon Horman > Sent: 07 February 2023 15:43 ... > However, amongst other usages of the return value, > those callers also check for a return < 0 from this function. > Can that occur, in the sprintf or scnprintf case? That rather depends on what happens with calls like: snprintf(NULL, 0, "*%s%*s", MAX_INT, "", MAX_INT, ""); That is a whole bag of worms you don't want to put your hand into. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)