From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-2.mimecast.com ([207.211.31.81]:50897 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727438AbfLILtT (ORCPT ); Mon, 9 Dec 2019 06:49:19 -0500 Subject: Re: [kvm-unit-tests PATCH v3 5/9] s390x: Library resources for CSS tests References: <1575649588-6127-1-git-send-email-pmorel@linux.ibm.com> <1575649588-6127-6-git-send-email-pmorel@linux.ibm.com> From: Thomas Huth Message-ID: <66233a15-7cc4-45b5-d930-abbedbd0729d@redhat.com> Date: Mon, 9 Dec 2019 12:49:09 +0100 MIME-Version: 1.0 In-Reply-To: <1575649588-6127-6-git-send-email-pmorel@linux.ibm.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Pierre Morel , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com On 06/12/2019 17.26, Pierre Morel wrote: > These are the include and library utilities for the css tests patch > series. > > Signed-off-by: Pierre Morel > --- > lib/s390x/css.h | 259 +++++++++++++++++++++++++++++++++++++++++++ > lib/s390x/css_dump.c | 156 ++++++++++++++++++++++++++ > 2 files changed, 415 insertions(+) > create mode 100644 lib/s390x/css.h > create mode 100644 lib/s390x/css_dump.c > > diff --git a/lib/s390x/css.h b/lib/s390x/css.h > new file mode 100644 > index 0000000..6f19bb5 > --- /dev/null > +++ b/lib/s390x/css.h [...] > +/* Debug functions */ > +char *dump_pmcw_flags(uint16_t f); > +char *dump_scsw_flags(uint32_t f); > +#undef DEBUG > +#ifdef DEBUG > +void dump_scsw(struct scsw *); > +void dump_irb(struct irb *irbp); > +void dump_schib(struct schib *sch); > +struct ccw *dump_ccw(struct ccw *cp); > +#else > +static inline void dump_scsw(struct scsw *scsw) {} > +static inline void dump_irb(struct irb *irbp) {} > +static inline void dump_pmcw(struct pmcw *p) {} > +static inline void dump_schib(struct schib *sch) {} > +static inline void dump_orb(struct orb *op) {} > +static inline struct ccw *dump_ccw(struct ccw *cp) > +{ > + return NULL; > +} > +#endif I'd prefer to not have a "#undef DEBUG" (or "#define DEBUG") statement in the header here - it could trigger unexpected behavior with other files that also use a DEBUG macro. Could you please declare the prototypes here and move the "#else" part to the .c file instead? Thanks! Thomas