From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [PATCH] drivers/s390/virtio: Remove the old KVM virtio transport Date: Wed, 27 Sep 2017 15:06:55 +0200 Message-ID: <66822fa4-f7fe-565a-bc51-9fe1493378f9@redhat.com> References: <1506512521-2244-1-git-send-email-thuth@redhat.com> <20170927125530.GE4032@osiris> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170927125530.GE4032@osiris> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Heiko Carstens Cc: Halil Pasic , Cornelia Huck , linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Christian Borntraeger , Martin Schwidefsky List-ID: On 27.09.2017 14:55, Heiko Carstens wrote: > On Wed, Sep 27, 2017 at 01:42:01PM +0200, Thomas Huth wrote: >> diff --git a/drivers/s390/virtio/Makefile b/drivers/s390/virtio/Makefile >> index df40692..d9942e0 100644 >> --- a/drivers/s390/virtio/Makefile >> +++ b/drivers/s390/virtio/Makefile >> @@ -7,7 +7,4 @@ >> # as published by the Free Software Foundation. >> >> s390-virtio-objs := virtio_ccw.o >> -ifdef CONFIG_S390_GUEST_OLD_TRANSPORT >> -s390-virtio-objs += kvm_virtio.o >> -endif >> obj-$(CONFIG_S390_GUEST) += $(s390-virtio-objs) > > Would you mind to simplify the Makefile to just the single line > > obj-$(CONFIG_S390_GUEST) += virtio_ccw.o > > while you are touching it anyway? Sure ... I'll send a v2 ... or do you rather want to fix it when picking up the patch? Thomas