From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71ED127D782 for ; Wed, 2 Jul 2025 14:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751465270; cv=none; b=iT3owioXij8W/bN8x+RIQufAHiwV8vQcQSeaTrZB8SOlDSNSZQ2XG//LS7TvfNQcodUHtXdcprMUFp1xvSWJPudnuaeiVD3QfyYIyvR8sERwOUcvsqSjcvVF/2VF53oLOamt735qY4WPjsm8LohAViugCUZMswSHeBFR8debqJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751465270; c=relaxed/simple; bh=JgM6uQPOSTPbn7vlABRvzmnevYaSVFtfopF3IcRPT3s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UVWFIhoRUTQbVKlO70fQ4dhVjKSCH04X8aW+YWE4yY6rKdUZJrXOL4O1NtnCy645Ohy5PGECB6uJObqdN7fVEvYFiH6xtCRuQ/8gZWgJL0L4BmGFMfKE674oLKlBhDHJpka4Xpm1FbwyB2GdMhIKldHVD6lE3LiU4Sbo3HCAHZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=W3nj7FYN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="W3nj7FYN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751465267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QtugXBwpmof8PtjrVGSF5iQiiRq53WoQXJVBl10e0QY=; b=W3nj7FYNTone4dR2rcLyY2nGIsKfua+T0DD4VUPrUfMUF41YDMF24SiBVYnZPtSG41tV/A noHtR4uEqSHUkBiDA7fGWEJqjIrEwOtNu0LxC82pjRRj9EhSRjEqzjzhDCTGCyB9BmmxBE ImeVTWJ4u7JKV4OK9+8i9T+B0WlmYEg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-kbOzbMNaOBqjMRrO-r_Sug-1; Wed, 02 Jul 2025 10:07:46 -0400 X-MC-Unique: kbOzbMNaOBqjMRrO-r_Sug-1 X-Mimecast-MFC-AGG-ID: kbOzbMNaOBqjMRrO-r_Sug_1751465265 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-451d3f03b74so36209535e9.3 for ; Wed, 02 Jul 2025 07:07:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751465265; x=1752070065; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QtugXBwpmof8PtjrVGSF5iQiiRq53WoQXJVBl10e0QY=; b=qumBpB7aAgLNsq5ry+ATtO/YcngX4Kp0P7EctQPhHAGWf5t8l9T0wGnWNVSEZVZG+D tyJYjmwvFSf2DlGmpDiSSe/yCBgpSXc39mgwIy7H86j4+kFq0kow+h/hkxSMD+i2cQr3 MjwLKoUrS4Dta9KukOKYbuqwKCqMB9ugMThKt5vZWJNb0GMrLsX+TbeOYG3bvpL9R29h LdwFjzcmep+jdH9IxiLf6AqZhnlIjSvu/6gj4rb8ip8sEhUrWFTwnJ95tFViHTahDHDK p3bDLsVjzWYJscmboEpUzTwFf1tR4ZUWlW7qmmsjQbO0mJ8Ktyzt1KsTOxPav/Ho4RUp 4bKg== X-Forwarded-Encrypted: i=1; AJvYcCUc5bwnVf6yyV69eKaD49j5XAWPe/d3s5L25URgOUtyQ3LrBCfjHHHd57sYdrOGlcdoObN6HGSSqF9J@vger.kernel.org X-Gm-Message-State: AOJu0YyvfJarE1D8OTOIfaPZLg0tNxHB1w/COkaRDZguSFmEAXPByzb7 y3EUacmyVPQzZcJ7c801274MMURjGB6fjQ58ZfInPijhINgY3jzExovWa+epppRXb69/9aWjSj0 upv9xFi/Sy+1/rldQ0Pofe5WmN8rvrXXYmKRz3XfVGgB7oqZPDe7gmbRDq6lCZ78= X-Gm-Gg: ASbGncv+Aq5dCTQNX1lR0vSsru8ei412OAUhQ3olR42lWH0264+ZdVMMofpckk1WWno tPoHBmVF0Qn5vjXU321hAafXS6PcmmMbOLsC3anFwdsfZ7w/A6l5jj+Jl+VCl02+p6HPUKu3G3/ SvIzGwXtGrq/TQu9iPPy+dzSYJMItTwYz/A/xKe0cL9xZD0EecfB1wXYs0aolxfe7PRw+JeW9km ik9EjlJuBcrhLhnWe4x3Osj/DvSNkOK/UyX8i5BJ3qVbv4mdh2DlvFqMO3LQcq0IrHcvDJWBSS4 vxRalbVYxpUPUd7YheOFApZ7XLlPWGzgqasZGawzF3Yepc+wngbvs19mSwI3+w== X-Received: by 2002:a05:600c:3b01:b0:453:99f:b1b0 with SMTP id 5b1f17b1804b1-454a3706e45mr28815115e9.20.1751465263155; Wed, 02 Jul 2025 07:07:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5YuCq5rpUy6RMv0jfgdQbgLyOb/XAUKuoXtz40yFdPi0MgOsaJG33C7l4K2KM2eHAFCoDsQ== X-Received: by 2002:a05:600c:3b01:b0:453:99f:b1b0 with SMTP id 5b1f17b1804b1-454a3706e45mr28812865e9.20.1751465261164; Wed, 02 Jul 2025 07:07:41 -0700 (PDT) Received: from [192.168.0.6] (ltea-047-064-114-041.pools.arcor-ip.net. [47.64.114.41]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453a85b3d44sm36303505e9.0.2025.07.02.07.07.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 07:07:40 -0700 (PDT) Message-ID: <69c1b5df-2b49-4a3c-811c-ad6141a22dbe@redhat.com> Date: Wed, 2 Jul 2025 16:07:39 +0200 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [kvm-unit-tests PATCH 1/2] scripts: unittests.cfg: Rename 'extra_params' to 'qemu_params' To: Alexandru Elisei , kvm@vger.kernel.org, andrew.jones@linux.dev, lvivier@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, nrb@linux.ibm.com, pbonzini@redhat.com, eric.auger@redhat.com, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, david@redhat.com, linux-s390@vger.kernel.org Cc: Shaoqin Huang References: <20250625154354.27015-1-alexandru.elisei@arm.com> <20250625154354.27015-2-alexandru.elisei@arm.com> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250625154354.27015-2-alexandru.elisei@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25/06/2025 17.43, Alexandru Elisei wrote: > The arm and arm64 architectures can also be run with kvmtool, and work is > under way to have it supported by the run_tests.sh test runner. Not > suprisingly, kvmtool's syntax for running a virtual machine is different to > qemu's. > > Add a new unittest parameter, 'qemu_params', with the goal to add a similar > parameter for kvmtool, when that's supported. > > 'extra_params' has been kept in the scripts as an alias for 'qemu_params' > to preserve compatibility with custom test definition, but it is expected > that going forward new tests will use 'qemu_params'. > > Reviewed-by: Andrew Jones > Reviewed-by: Shaoqin Huang > Signed-off-by: Alexandru Elisei > --- ... > diff --git a/docs/unittests.txt b/docs/unittests.txt > index c4269f6230c8..3d19fd70953f 100644 > --- a/docs/unittests.txt > +++ b/docs/unittests.txt > @@ -24,9 +24,9 @@ param = value format. > > Available parameters > ==================== > -Note! Some parameters like smp and extra_params modify how a test is run, > -while others like arch and accel restrict the configurations in which the > -test is run. > +Note! Some parameters like smp and qemu_params/extra_params modify how a > +test is run, while others like arch and accel restrict the configurations > +in which the test is run. > > file > ---- > @@ -56,13 +56,18 @@ smp = > Optional, the number of processors created in the machine to run the test. > Defaults to 1. $MAX_SMP can be used to specify the maximum supported. > > -extra_params > +qemu_params > ------------ Please adjust the length of the "---" line now, too. With that nit fixed: Acked-by: Thomas Huth