Re: [kvm-unit-tests PATCH 1/2] s390x: Fix misspelt variable name in func.bash

Janosch Frank
2024-04-18T11:10:58Z

On 4/16/24 04:29, Nicholas Piggin wrote:
> On Thu Apr 11, 2024 at 7:40 PM AEST, Janosch Frank wrote:
>> On 4/10/24 06:35, Nicholas Piggin wrote:
>>> On Mon Apr 8, 2024 at 9:59 PM AEST, Janosch Frank wrote:
>>>> On 4/6/24 14:24, Nicholas Piggin wrote:
>>>>> The if statement is intended to run non-migration tests with PV on KVM.
>>>>> With the misspelling, they are run on KVM or TCG.
>>>>>
>>>>
>>>> It's not misspelt, is it?
>>>> It's in the wrong case.
>>>
>>> Yes, that's the right word.
>>>
>>>>
>>>>
>>>> I'm fine with the code though.
>>>
>>> Thanks, I'll take that as an Acked-by: you
>>
>> Could you send out a fixed version that I can pick or do you want me to
>> fix that up?
>
> I was going to at some point, but was juggling a bunch of other
> things and have some travel and vacation. You are welcome to take
> over them if you like it would be helpful.
>

Same here, I'll be on vacation starting next week so I've prepared a
branch with your patches for Nico and Claudio which they can send out
when I'm on vacation.