From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: [PATCH 13/17] s390/debug: Improve a size determination in debug_open() References: <566ABCD9.1060404@users.sourceforge.net> From: SF Markus Elfring Message-ID: <6f816bfa-ea0b-dd1a-24ba-5aeea7519276@users.sourceforge.net> Date: Sat, 3 Sep 2016 14:32:06 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: linux-s390@vger.kernel.org, David Hildenbrand , Heiko Carstens , Joe Perches , Martin Schwidefsky Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini List-ID: From: Markus Elfring Date: Fri, 2 Sep 2016 09:02:22 +0200 * Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. * Improve source code layout for one function call. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c index a9fcf72..32ceb5e 100644 --- a/arch/s390/kernel/debug.c +++ b/arch/s390/kernel/debug.c @@ -636,8 +636,7 @@ debug_open(struct inode *inode, struct file *file) rc = -ENOMEM; goto unlock; } - p_info = kmalloc(sizeof(file_private_info_t), - GFP_KERNEL); + p_info = kmalloc(sizeof(*p_info), GFP_KERNEL); if (!p_info) { debug_info_free(debug_info_snapshot); rc = -ENOMEM; -- 2.9.3