From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D9CFC6FD19 for ; Thu, 16 Mar 2023 11:15:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbjCPLO7 (ORCPT ); Thu, 16 Mar 2023 07:14:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230272AbjCPLO4 (ORCPT ); Thu, 16 Mar 2023 07:14:56 -0400 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 320FEEB; Thu, 16 Mar 2023 04:14:32 -0700 (PDT) Received: by mail-wm1-f49.google.com with SMTP id bh21-20020a05600c3d1500b003ed1ff06fb0so823167wmb.3; Thu, 16 Mar 2023 04:14:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678965270; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2ZDBT0cMZ0W19lPDUhO8A3SC8gJRP8pNHC7vkw5YBWs=; b=m7h4cvpVhloSYFgu3RtK71cLUIHCV2B2Xc3/kzbe7SoK4p1wJ/5uwSXXmTQcXJBYJ1 N3fRhoSQK/hjvI11RjN/ga8mAMftWPM7XO/zk0T2voVXktH8ugBtSB4oWxs6KjAyGMlJ lggGGONnPsXTEG5POp1uLgJxemPKROQN82UwtJuM0w2I0DWo9bLVtTkSI3PysRbP0WOR TLhIPxmGD3zBSUXl2jw2ebtn/Yr88ZfXU6KE2W4GeTKckD8todb/sdI+NirGuKRfIHBm 5jiqR8c1Bl5CydZMajejcDYYc2HUmHA5tQIJsPHt5MyEurIYvPDMSJr/ha70oqIGRgd9 /E2w== X-Gm-Message-State: AO0yUKUdp/0CFqAdxsEKISaw6vbR196RFWYKCnVcBZZsi4P53GlCr+fU iGMpfuAEqTnvJhM6cNPo0obxay2Kto8= X-Google-Smtp-Source: AK7set+u7sPC1b8dhu6zYooEMDkVjysjW+tBZ0xjaRmULDxxhCOU9R0dfR3BrzDHYj9d5TdjWFQXRg== X-Received: by 2002:a05:600c:4448:b0:3dc:1687:9ba2 with SMTP id v8-20020a05600c444800b003dc16879ba2mr20542511wmn.35.1678965270508; Thu, 16 Mar 2023 04:14:30 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:49? ([2a0b:e7c0:0:107::aaaa:49]) by smtp.gmail.com with ESMTPSA id k6-20020a05600c1c8600b003e209b45f6bsm5082683wms.29.2023.03.16.04.14.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 04:14:29 -0700 (PDT) Message-ID: <705ce64c-5f73-2ec8-e4bc-dd48c85f0498@kernel.org> Date: Thu, 16 Mar 2023 12:14:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2] s390/nospec: remove unneeded header includes Content-Language: en-US To: Vasily Gorbik , Joe Lawrence Cc: Michael Ellerman , Sumanth Korikkar , Heiko Carstens , Masahiro Yamada , linux-s390 , linux-kbuild@vger.kernel.org References: <8569429d-57f8-a0cf-8b17-1291f6973d32@redhat.com> From: Jiri Slaby In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 27. 06. 22, 14:50, Vasily Gorbik wrote: > Commit 4efd417f298b ("s390: raise minimum supported machine generation > to z10") removed the usage of alternatives and lowcore in expolines > macros. Remove unneeded header includes as well. > > With that, expoline.S doesn't require asm-offsets.h and > expoline_prepare target dependency could be removed. > > Signed-off-by: Vasily Gorbik > --- > arch/s390/Makefile | 2 +- > arch/s390/include/asm/nospec-insn.h | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/s390/Makefile b/arch/s390/Makefile > index fc72a35a1f07..4cb5d17e7ead 100644 > --- a/arch/s390/Makefile > +++ b/arch/s390/Makefile > @@ -166,7 +166,7 @@ vdso_prepare: prepare0 > > ifdef CONFIG_EXPOLINE_EXTERN > modules_prepare: expoline_prepare > -expoline_prepare: prepare0 > +expoline_prepare: Hi, this likely broke s390 build as expolines still depend on scripts/basic/fixdep. And build of expolines can now race with fixdep build: make[1]: *** Deleting file 'arch/s390/lib/expoline/expoline.o' /bin/sh: line 1: scripts/basic/fixdep: Permission denied make[1]: *** [../scripts/Makefile.build:385: arch/s390/lib/expoline/expoline.o] Error 126 make: *** [../arch/s390/Makefile:166: expoline_prepare] Error 2 I returned there: expoline_prepare: prepare0 and it looks good so far. Maybe even: expoline_prepare: scripts would be enough. Opinions? thanks, -- js suse labs