From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732117AbgF3Nyu (ORCPT ); Tue, 30 Jun 2020 09:54:50 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1326C03E97E for ; Tue, 30 Jun 2020 06:54:49 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id bj10so3278398plb.11 for ; Tue, 30 Jun 2020 06:54:49 -0700 (PDT) Subject: Re: [PATCH 11/20] fs: remove a weird comment in submit_bh_wbc References: <20200629193947.2705954-1-hch@lst.de> <20200629193947.2705954-12-hch@lst.de> From: Jens Axboe Message-ID: <70e8de25-4e26-9c00-1492-e433ebfdbc90@kernel.dk> Date: Tue, 30 Jun 2020 07:54:46 -0600 MIME-Version: 1.0 In-Reply-To: <20200629193947.2705954-12-hch@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Christoph Hellwig Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linuxppc-dev@lists.ozlabs.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org On 6/29/20 1:39 PM, Christoph Hellwig wrote: > All bios can get remapped if submitted to partitions. No need to > comment on that. I'm pretty sure that comment is from me, dating back to when the bio code was introduced in 2001. The point wasn't the remapping, just that from here on down the IO was purely bio based, not buffer_heads. Anyway, totally agree that it should just die, it's not that interesting or useful anymore. -- Jens Axboe