From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AD84219ED for ; Wed, 27 Mar 2024 02:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711505483; cv=none; b=fJm/uMrVqsrC8paQ6GgQhAxQhXdmV+3AOGUv1dhIa8lzXVbnaKhvSqNIKd/svQGTnDKno1twk2VSKDnTCF9+oyzkOSH/Pzmz+ubMEvtxkoYHlRphoK7CfvyH54B8T6X9Eb4ZATUBjL5hklXsYeqgUR2R6TlEe9fgZDB6un/DZkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711505483; c=relaxed/simple; bh=y2aifghtI/Ja4XD7u2NtI6N6MTi5BLIEicHNNSMA6SA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V/7W5taRe94bzetJhabtaz9PRmAITa7oE2mApO+yaIOeXqqoT80v/9abPUmHhkoS5GkINbJKlZ2HiNghoXut/2jTWNRkLygzVfojvhQrQAgwcdzf6dF1DRAWfsxIN32UZQOUbM7Aw/PbYZrE0b2vKtJ6sjurIrF6c1AKTI7k+Dg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=JxRsfOQn; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="JxRsfOQn" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-29f8403166aso1058051a91.1 for ; Tue, 26 Mar 2024 19:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1711505480; x=1712110280; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VKgEZz3gqT/qrPZJxtA6ePPIz6oGvyMPjM3uA1fFlqE=; b=JxRsfOQn8gPSjir6TbrBjWXbK/PJp4ZBSwKtWzwl58PgosmH2htE9+JnrFwfbnzQ2G /qa55/418mac0pI1hfo5vRwTNvgu60YzGuXXTWbPdw4xSCbU9P28mRYteMbrcz9qhLMx fFGwlRPa9ESvMcE90yEh8E3G8fD3dm/8iyo6Cnmor6/SsdhSPMMVI0G/c080B2KXbSsJ 95pGqI7L+x9Fw3E6nJNoAc7GSEbX+N1sOw/7QDH9RCfJYh387NdNn+ocZ9vI757IaxX+ 3OQeXlXkwK+CZSWR1+VNrrJC4rkxeNAlNhGjmxE6yE4ylVRFrSEZiQfYLqdseXO/8ud7 F5Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711505480; x=1712110280; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VKgEZz3gqT/qrPZJxtA6ePPIz6oGvyMPjM3uA1fFlqE=; b=vj4efD+V7AasSOZWIHKlXidMNX3cB1qsjfm+LEQQl3R6SA2rhmQy7h6PvgFz+KiEwm zdSAArAKj7T3o7N3Pqkdvql98F3sn9nu9j8GqFB5wWrpXzuX97iJ3ue0lCidIhuCY/uk /MSBGQT+SMqVG+kRh1mlijBYwhPbzWZexx36Rny59E4o5MXzFAhxlAP7d9f9t5Gp1boc s037kwNiMA5kzP+SsHTr4NcH6MTlemlIYxU/48KO9rsWD+LQrPAJxGTC9q8qurBRql/8 MgRZcICD0ZCMhR1kwESLlAoc4t1eOkf7oq3/LyzYl4IoSJSw0eizAfSosBzNrOOrn5na k2Yw== X-Forwarded-Encrypted: i=1; AJvYcCWMCMkMhcCjiIn/aARQdDmhwF37BajqoaMmO4wsxtVOCYQYzJWq54Cthltmor7Nqv+JAkTj/512mylVz0fz5LNf/DJJAI5PeKfZ3g== X-Gm-Message-State: AOJu0YxWsIQAsfwOTiB7G/YIVQeRaVuCdYHX4SB2syzufT70NMjCHz1H YpMMMAEOjsThkeEJeA+v5kdftua3jdAWJXximmSc8p3BI3yHM6DUih2zsGuwwXo= X-Google-Smtp-Source: AGHT+IHOxzsYzXYb2U6hVOGVogL6FmVfZp9EHnweMdH3lzP+3KV1JbtDB3TMm+JsCmDJCYsexHcneA== X-Received: by 2002:a17:90a:9f8b:b0:29b:fab2:8a24 with SMTP id o11-20020a17090a9f8b00b0029bfab28a24mr10290068pjp.3.1711505480542; Tue, 26 Mar 2024 19:11:20 -0700 (PDT) Received: from [10.254.105.249] ([139.177.225.230]) by smtp.gmail.com with ESMTPSA id q5-20020a17090ac10500b0029becfcb97esm335753pjt.22.2024.03.26.19.11.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 19:11:20 -0700 (PDT) Message-ID: <7258d29d-0d4b-4463-8685-e3f21d426d2d@bytedance.com> Date: Wed, 27 Mar 2024 10:11:13 +0800 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] s390: supplement for ptdesc conversion Content-Language: en-US To: Vishal Moola Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, rppt@kernel.org, willy@infradead.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-s390@vger.kernel.org References: <04beaf3255056ffe131a5ea595736066c1e84756.1709541697.git.zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/3/27 03:48, Vishal Moola wrote: > On Mon, Mar 04, 2024 at 07:07:20PM +0800, Qi Zheng wrote: >> --- a/arch/s390/mm/gmap.c >> +++ b/arch/s390/mm/gmap.c >> @@ -206,9 +206,11 @@ static void gmap_free(struct gmap *gmap) >> >> /* Free additional data for a shadow gmap */ >> if (gmap_is_shadow(gmap)) { >> + struct ptdesc *ptdesc; >> + >> /* Free all page tables. */ >> - list_for_each_entry_safe(page, next, &gmap->pt_list, lru) >> - page_table_free_pgste(page); >> + list_for_each_entry_safe(ptdesc, next, &gmap->pt_list, pt_list) >> + page_table_free_pgste(ptdesc); > > An important note: ptdesc allocation/freeing is different than the > standard alloc_pages()/free_pages() routines architectures are used to. > Are we sure we don't have memory leaks here? > > We always allocate and free ptdescs as compound pages; for page table > struct pages, most archictectures do not. s390 has CRST_ALLOC_ORDER > pagetables, meaning if we free anything using the ptdesc api, we better > be sure it was allocated using the ptdesc api as well. According to the code inspection, all ptdescs added to the pmap->pt_list are allocated via page_table_alloc_pgste(). > > Like you, I don't have a s390 to test on, so hopefully some s390 expert > can chime in to let us know if we need a fix for this. Yes, hope so!