Re: [kvm-unit-tests PATCH v2 2/7] s390x: smp: Only use smp_cpu_setup once

Janosch Frank
2020-01-16T13:02:01Z

[-- Attachment #1.1: Type: text/plain, Size: 2815 bytes --]

On 1/16/20 1:18 PM, David Hildenbrand wrote:
> On 16.01.20 13:05, Janosch Frank wrote:
>> Let's stop and start instead of using setup to run a function on a
>> cpu.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>> ---
>> s390x/smp.c | 20 +++++++++++++-------
>> 1 file changed, 13 insertions(+), 7 deletions(-)
>>
>> diff --git a/s390x/smp.c b/s390x/smp.c
>> index 02204fd..d430638 100644
>> --- a/s390x/smp.c
>> +++ b/s390x/smp.c
>> @@ -47,7 +47,7 @@ static void test_start(void)
>> psw.mask = extract_psw_mask();
>> psw.addr = (unsigned long)test_func;
>>
>> - smp_cpu_setup(1, psw);
>> + smp_cpu_start(1, psw);
>> wait_for_flag();
>> report(1, "start");
>> }
>> @@ -132,9 +132,8 @@ static void test_ecall(void)
>>
>> report_prefix_push("ecall");
>> testflag = 0;
>> - smp_cpu_destroy(1);
>>
>> - smp_cpu_setup(1, psw);
>> + smp_cpu_start(1, psw);
>> wait_for_flag();
>> testflag = 0;
>> sigp(1, SIGP_EXTERNAL_CALL, 0, NULL);
>> @@ -167,9 +166,8 @@ static void test_emcall(void)
>>
>> report_prefix_push("emcall");
>> testflag = 0;
>> - smp_cpu_destroy(1);
>>
>> - smp_cpu_setup(1, psw);
>> + smp_cpu_start(1, psw);
>> wait_for_flag();
>> testflag = 0;
>> sigp(1, SIGP_EMERGENCY_SIGNAL, 0, NULL);
>> @@ -187,7 +185,7 @@ static void test_reset_initial(void)
>> psw.addr = (unsigned long)test_func;
>>
>> report_prefix_push("reset initial");
>> - smp_cpu_setup(1, psw);
>> + smp_cpu_start(1, psw);
>>
>> sigp_retry(1, SIGP_INITIAL_CPU_RESET, 0, NULL);
>> sigp(1, SIGP_STORE_STATUS_AT_ADDRESS, (uintptr_t)status, NULL);
>> @@ -218,7 +216,7 @@ static void test_reset(void)
>> psw.addr = (unsigned long)test_func;
>>
>> report_prefix_push("cpu reset");
>> - smp_cpu_setup(1, psw);
>> + smp_cpu_start(1, psw);
>>
>> sigp_retry(1, SIGP_CPU_RESET, 0, NULL);
>> report(smp_cpu_stopped(1), "cpu stopped");
>> @@ -227,6 +225,7 @@ static void test_reset(void)
>>
>> int main(void)
>> {
>> + struct psw psw;
>> report_prefix_push("smp");
>>
>> if (smp_query_num_cpus() == 1) {
>> @@ -234,6 +233,12 @@ int main(void)
>> goto done;
>> }
>>
>> + /* Setting up the cpu to give it a stack and lowcore */
>> + psw.mask = extract_psw_mask();
>> + psw.addr = (unsigned long)cpu_loop;
>> + smp_cpu_setup(1, psw);
>> + smp_cpu_stop(1);
>> +
>> test_start();
>> test_stop();
>> test_stop_store_status();
>> @@ -242,6 +247,7 @@ int main(void)
>> test_emcall();
>> test_reset();
>> test_reset_initial();
>> + smp_cpu_destroy(1);
>>
>> done:
>> report_prefix_pop();
>>
>
> Acked-by: David Hildenbrand <david@redhat.com>
Thanks!

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]