Re: [PATCH v2 02/20] s390/ap/zcrypt: Rework AP message buffer allocation

Holger Dengler
2025-03-17T13:57:54Z

On 04/03/2025 18:20, Harald Freudenberger wrote:
> Slight rework on the way how AP message buffers are allocated.
> Instead of having multiple places with kmalloc() calls all
> the AP message buffers are now allocated and freed on exactly
> one place: ap_init_apmsg() allocates the current AP bus max
> limit of ap_max_msg_size (defaults to 12KB). The AP message
> buffer is then freed in ap_release_apmsg().
>
> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>

Reviewed-by: Holger Dengler <dengler@linux.ibm.com>

> ---
> drivers/s390/crypto/ap_bus.c | 30 ++++++++++++++++
> drivers/s390/crypto/ap_bus.h | 21 ++---------
> drivers/s390/crypto/zcrypt_api.c | 49 +++++++++++++++-----------
> drivers/s390/crypto/zcrypt_msgtype50.c | 20 ++++++-----
> drivers/s390/crypto/zcrypt_msgtype6.c | 35 +++++++++---------
> 5 files changed, 90 insertions(+), 65 deletions(-)

--
Mit freundlichen Grüßen / Kind regards
Holger Dengler
--
IBM Systems, Linux on IBM Z Development
dengler@linux.ibm.com