Re: [kvm-unit-tests PATCH v4 7/9] s390x: smp: Remove unneeded cpu loops

David Hildenbrand
2020-01-21T17:37:01Z

On 21.01.20 14:42, Janosch Frank wrote:
> Now that we have a loop which is executed after we return from the
> main function of a secondary cpu, we can remove the surplus loops.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/smp.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/s390x/smp.c b/s390x/smp.c
> index 3e8cf3e..45f1d80 100644
> --- a/s390x/smp.c
> +++ b/s390x/smp.c
> @@ -35,15 +35,9 @@ static void set_flag(int val)
> mb();
> }
>
> -static void cpu_loop(void)
> -{
> - for (;;) {}
> -}
> -
> static void test_func(void)
> {
> set_flag(1);
> - cpu_loop();
> }
>
> static void test_start(void)
> @@ -241,7 +235,7 @@ int main(void)
>
> /* Setting up the cpu to give it a stack and lowcore */
> psw.mask = extract_psw_mask();
> - psw.addr = (unsigned long)cpu_loop;
> + psw.addr = (unsigned long)test_func;
> smp_cpu_setup(1, psw);
> smp_cpu_stop(1);
>
>

Acked-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb