Re: [PATCH] KVM: s390: Move two error code assignments in kvm_vm_ioctl_get_dirty_log()

Paolo Bonzini
2017-01-23T09:19:56Z

On 23/01/2017 09:22, Christian Borntraeger wrote:
> Patches that changes open coded things to common helpers or things like
> kmalloc_array where appropriate or things that make the code more robust
> are fine and welcome, but I am not going to take this as it just shuffles
> things around. It does not fix anything and it does not improve the code,
> but it certainly carries the risk of breaking something (yes in this case
> it looks perfectly fine, though).

Besides,

r = -ESOMETHING;
if (...)
return r;

is the way it's done everywhere else in KVM.

Paolo