From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CC14A1ABEB7; Fri, 20 Dec 2024 10:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734692301; cv=none; b=hHmzX/BicmrECwVQ1DtAjyyksNspS6kt3VX4yVhJp9FXdsLE2Je2jtH+uOPw/0rnoHAYng0Bij2EInCquXkQVDWL1ozR9ooC8UEj7xzuGTmDMCeIr6m7tTJwn2g6MyMT0pSA/5Yg9ePMgLqXamVSYyl4ssS9UQZl4lwQpbFsTyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734692301; c=relaxed/simple; bh=zBx2G/uyr1DsWaYTCu2FJk2j9r8nBvoTt83AewYBXVI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O008qeacho8fHfzmV4UhgRnK56iTF/TXmNEG9TZyyxTitrm1xDDZTT+LiH3UuoOiFXeIzydYuwZETFzzBPhOrELiO6Wy4z50PJwqgforpegEr2Yh7pPNau5/kodSehwUK2GF63cHZky/v3xTlk4/XQPkd5fKxj2leze+aG8GQoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4DDC71480; Fri, 20 Dec 2024 02:58:47 -0800 (PST) Received: from [10.57.72.191] (unknown [10.57.72.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0C613F58B; Fri, 20 Dec 2024 02:58:10 -0800 (PST) Message-ID: <765aec36-55a4-4161-bb30-4ff838bc2d98@arm.com> Date: Fri, 20 Dec 2024 11:58:08 +0100 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] Account page tables at all levels To: Dave Hansen , linux-mm@kvack.org Cc: Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , Peter Zijlstra , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org References: <20241219164425.2277022-1-kevin.brodsky@arm.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/12/2024 18:13, Dave Hansen wrote: > On 12/19/24 08:44, Kevin Brodsky wrote: >> +---------------+-------------------------+-----------------------+--------------+------------------------------------+ >> | x86 | Y | Y | Y/N | kmem_cache at pgd level if PAE | >> +---------------+-------------------------+-----------------------+--------------+------------------------------------+ > This is a really rare series that adds functionality _and_ removes code > overall. It looks really good to me. The x86 implementation seems to be > captured just fine in the generic one: Thank you for the review, very appreciated! > Acked-by: Dave Hansen Just to double-check, are your ack'ing the x86 changes specifically? If so I'll add your Acked-by on patch 6, 7 and 9. > One super tiny nit is that the PAE pgd _can_ be allocated using > __get_free_pages(). It was originally there for Xen, but I think it's > being used for PTI only at this point and the comments are wrong-ish. > > I kinda think we should just get rid of the 32-bit kmem_cache entirely. That would certainly simplify things on the x86 side! I'm not at all familiar with that code though, would you be happy with providing a patch? I could add it to this series if that's convenient. - Kevin