From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:28474 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725970AbgKRQhS (ORCPT ); Wed, 18 Nov 2020 11:37:18 -0500 Subject: Re: md: dm-writeback: add __noreturn to BUG-ging function References: <20201113225228.20563-1-rdunlap@infradead.org> <344abf76-9405-58ba-2dc4-27cab88c974d@de.ibm.com> <20201117163147.GA27243@redhat.com> <20201118154944.GB545@redhat.com> <20201118160748.GA754@redhat.com> From: Christian Borntraeger Message-ID: <7ae2b73e-e6e5-3357-11e4-efd93e93ba35@de.ibm.com> Date: Wed, 18 Nov 2020 17:35:49 +0100 In-Reply-To: <20201118160748.GA754@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit MIME-Version: 1.0 List-ID: To: Mike Snitzer , Randy Dunlap Cc: linux-kernel@vger.kernel.org, Mikulas Patocka , Alasdair Kergon , dm-devel@redhat.com, Heiko Carstens , Vasily Gorbik , linux-s390@vger.kernel.org On 18.11.20 17:07, Mike Snitzer wrote: > On Wed, Nov 18 2020 at 10:49am -0500, > Mike Snitzer wrote: > >> I don't think my suggestion will help.. given it'd still leave >> persistent_memory_claim() without a return statement. >> >> Think it worthwhile to just add a dummy 'return 0;' after the BUG(). > > Decided to go with this, now staged for 5.11: > https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.11&id=a1e4865b4dda7071f3707f7e551289ead66e38b1 > Looks like a sane solution. Thank you for following up.