From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] s390/boot: block uncompressed vmlinux booting attempts References: <64bcba64-b88f-3594-da6e-7c2118482c20@roeck-us.net> From: Christian Borntraeger Date: Tue, 26 Jun 2018 09:30:19 +0200 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Message-Id: <7cb526fc-9da4-248b-d5c4-cb463a2c2bac@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Vasily Gorbik , Martin Schwidefsky Cc: Heiko Carstens , Cornelia Huck , Guenter Roeck , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, qemu-s390x , qemu-devel , Thomas Huth List-ID: On 06/25/2018 05:09 PM, Vasily Gorbik wrote: > Since uncompressed kernel image "vmlinux" elf file is not bootable under > qemu anymore, add a check which would report that. > > Qemu users are encouraged to use bzImage or > arch/s390/boot/compressed/vmlinux instead. > > The check relies on s390 linux entry point ABI definition, which is only > present in bzImage and arch/s390/boot/compressed/vmlinux. > > Signed-off-by: Vasily Gorbik Acked-by: Christian Borntraeger some proposals regarding the wording below.. [...] > + > + sclp_early_printk("The linux kernel boot failure: the image is corrupted or not bootable.\n"); > + sclp_early_printk("Please check that you are using bootable kernel image \"bzImage\".\n"); > + sclp_early_printk("(or alternatively \"arch/s390/boot/compressed/vmlinux\" image for qemu)\n"); What about making this explain things a bit more, e.g. something like Linux kernel boot failure: The boot image does not contain all necessary components (like the entry point and decompressor). The plain vmlinux ELF file no longer carries all necessary parts for starting up. Please use bzImage or arch/s390/boot/compressed/vmlinux.