From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com ([205.139.110.61]:34777 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727004AbgBDJU2 (ORCPT ); Tue, 4 Feb 2020 04:20:28 -0500 Subject: Re: [PATCH v6 08/10] mm/memory_hotplug: Don't check for "all holes" in shrink_zone_span() References: <20191006085646.5768-1-david@redhat.com> <20191006085646.5768-9-david@redhat.com> <20200204091312.GC6494@linux> From: David Hildenbrand Message-ID: <7d36f4cd-3f5b-8fec-2d8b-83e62a34ec89@redhat.com> Date: Tue, 4 Feb 2020 10:20:16 +0100 MIME-Version: 1.0 In-Reply-To: <20200204091312.GC6494@linux> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, x86@kernel.org, Andrew Morton , Michal Hocko , Pavel Tatashin , Dan Williams , Wei Yang On 04.02.20 10:13, Oscar Salvador wrote: > On Sun, Oct 06, 2019 at 10:56:44AM +0200, David Hildenbrand wrote: >> If we have holes, the holes will automatically get detected and removed >> once we remove the next bigger/smaller section. The extra checks can >> go. >> >> Cc: Andrew Morton >> Cc: Oscar Salvador >> Cc: Michal Hocko >> Cc: David Hildenbrand >> Cc: Pavel Tatashin >> Cc: Dan Williams >> Cc: Wei Yang >> Signed-off-by: David Hildenbrand > > Heh, I have been here before. > I have to confess that when I wrote my version of this I was not really 100% > about removing it, because hotplug was a sort of a "catchall" for all sort of weird > and corner-cases configurations, but thinking more about it, I cannot think of > any situation that would make this blow up. > > Reviewed-by: Oscar Salvador Thanks for your review Oscar! -- Thanks, David / dhildenb