Re: [PATCH v2 10/10] s390x: Fix library constant definitions

David Hildenbrand
2020-04-24T10:13:31Z

On 23.04.20 11:10, Janosch Frank wrote:
> Seems like I uppercased the whole region instead of only the ULs when
> I added those definitions. Let's make the x lowercase again.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> ---
> lib/s390x/asm/arch_def.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
> index 15a4d49..1b3bb0c 100644
> --- a/lib/s390x/asm/arch_def.h
> +++ b/lib/s390x/asm/arch_def.h
> @@ -19,10 +19,10 @@ struct psw {
> #define PSW_MASK_DAT 0x0400000000000000UL
> #define PSW_MASK_PSTATE 0x0001000000000000UL
>
> -#define CR0_EXTM_SCLP 0X0000000000000200UL
> -#define CR0_EXTM_EXTC 0X0000000000002000UL
> -#define CR0_EXTM_EMGC 0X0000000000004000UL
> -#define CR0_EXTM_MASK 0X0000000000006200UL
> +#define CR0_EXTM_SCLP 0x0000000000000200UL
> +#define CR0_EXTM_EXTC 0x0000000000002000UL
> +#define CR0_EXTM_EMGC 0x0000000000004000UL
> +#define CR0_EXTM_MASK 0x0000000000006200UL
>
> struct lowcore {
> uint8_t pad_0x0000[0x0080 - 0x0000]; /* 0x0000 */
>

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb