From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6077BC433F5 for ; Mon, 1 Nov 2021 03:44:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C72460EE9 for ; Mon, 1 Nov 2021 03:44:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230237AbhKADqf (ORCPT ); Sun, 31 Oct 2021 23:46:35 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:26217 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbhKADqe (ORCPT ); Sun, 31 Oct 2021 23:46:34 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4HjJkw5k47z8ttn; Mon, 1 Nov 2021 11:42:32 +0800 (CST) Received: from kwepemm600016.china.huawei.com (7.193.23.20) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Mon, 1 Nov 2021 11:43:43 +0800 Received: from [10.67.102.67] (10.67.102.67) by kwepemm600016.china.huawei.com (7.193.23.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Mon, 1 Nov 2021 11:43:41 +0800 Subject: Re: [PATCH V5 net-next 6/6] net: hns3: remove the way to set tx spare buf via module parameter To: Andrew Lunn CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20211030131001.38739-1-huangguangbin2@huawei.com> <20211030131001.38739-7-huangguangbin2@huawei.com> From: "huangguangbin (A)" Message-ID: <84f977be-d2df-0927-fb43-c7afae373bd1@huawei.com> Date: Mon, 1 Nov 2021 11:43:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.67] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600016.china.huawei.com (7.193.23.20) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 2021/10/31 2:05, Andrew Lunn wrote: > On Sat, Oct 30, 2021 at 09:10:01PM +0800, Guangbin Huang wrote: >> From: Hao Chen >> >> The way to set tx spare buf via module parameter is not such >> convenient as the way to set it via ethtool. >> >> So,remove the way to set tx spare buf via module parameter. >> >> Signed-off-by: Hao Chen >> Signed-off-by: Guangbin Huang >> --- >> drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c >> index 076631d7727d..032547a2ad2f 100644 >> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c >> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c >> @@ -53,10 +53,6 @@ static int debug = -1; >> module_param(debug, int, 0); >> MODULE_PARM_DESC(debug, " Network interface message level setting"); >> >> -static unsigned int tx_spare_buf_size; >> -module_param(tx_spare_buf_size, uint, 0400); >> -MODULE_PARM_DESC(tx_spare_buf_size, "Size used to allocate tx spare buffer"); >> - > > This might be considered ABI. By removing it, are you breaking users > setup? > > Andrew > . > Yes, patch 1/6 and 2/6 add support for ethtool to set tx spare(copybreak) buf size, so remove the way to set it by module parameter.