From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41232C48BDF for ; Tue, 15 Jun 2021 10:54:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26B0961454 for ; Tue, 15 Jun 2021 10:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231486AbhFOK45 (ORCPT ); Tue, 15 Jun 2021 06:56:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53669 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231609AbhFOK45 (ORCPT ); Tue, 15 Jun 2021 06:56:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623754492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZqntZMQGa2bhFYJFHzlo20p/iZVUpQp6FB0MmKPlUSA=; b=jViR4FYty7B0PJuTOVTe6ZvnRrk0lQr1L5dZrBgG+G4t0PJ5NWEkxTeJASL1+Ds+sscfof KVbSNFKX6fP0hcU7w9efqbhGhZcSgjvPRtV4n3t5LBDmxPFiFcthoarTMq91h6QUiJ+UVt sfyBdycS63NR1s/LuB0zyGt8meGFcxQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-473-MzAsXP33NpemjdQ5dDKulw-1; Tue, 15 Jun 2021 06:54:51 -0400 X-MC-Unique: MzAsXP33NpemjdQ5dDKulw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EFFEB10C1ADC; Tue, 15 Jun 2021 10:54:46 +0000 (UTC) Received: from localhost (ovpn-113-156.ams2.redhat.com [10.36.113.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1010419C66; Tue, 15 Jun 2021 10:54:43 +0000 (UTC) From: Cornelia Huck To: Christoph Hellwig , Greg Kroah-Hartman , Jason Gunthorpe , Alex Williamson , Kirti Wankhede Cc: David Airlie , Tony Krowiak , Christian Borntraeger , Jonathan Corbet , Daniel Vetter , dri-devel@lists.freedesktop.org, Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, Jani Nikula , Jason Herne , Joonas Lahtinen , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Halil Pasic , "Rafael J. Wysocki" , Rodrigo Vivi Subject: Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind In-Reply-To: <20210614150846.4111871-8-hch@lst.de> Organization: Red Hat GmbH References: <20210614150846.4111871-1-hch@lst.de> <20210614150846.4111871-8-hch@lst.de> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 15 Jun 2021 12:54:41 +0200 Message-ID: <875yyfxury.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Mon, Jun 14 2021, Christoph Hellwig wrote: > From: Jason Gunthorpe > > This allows a mdev driver to opt out of using vfio_mdev.c, instead the > driver will provide a 'struct mdev_driver' and register directly with the > driver core. > > Much of mdev_parent_ops becomes unused in this mode: > - create()/remove() are done via the mdev_driver probe()/remove() > - mdev_attr_groups becomes mdev_driver driver.dev_groups > - Wrapper function callbacks are replaced with the same ones from > struct vfio_device_ops > > Signed-off-by: Jason Gunthorpe > Signed-off-by: Christoph Hellwig > --- > drivers/vfio/mdev/mdev_core.c | 30 ++++++++++++++++++++++-------- > drivers/vfio/mdev/mdev_driver.c | 10 ++++++++++ > include/linux/mdev.h | 2 ++ > 3 files changed, 34 insertions(+), 8 deletions(-) Reviewed-by: Cornelia Huck