From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE57EECAAD2 for ; Mon, 29 Aug 2022 12:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229564AbiH2MEY (ORCPT ); Mon, 29 Aug 2022 08:04:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbiH2MD4 (ORCPT ); Mon, 29 Aug 2022 08:03:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE5AB9BB76 for ; Mon, 29 Aug 2022 04:49:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661773676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ab0J6P8U/r6Cnl9kTb0FuzLIbBDJFAgg8fopygncHGw=; b=H1lfVkJAhDKSjaRb0bxWjMTU6QB3Ea0YRCrMU3277bam7c65vdV8ob3gzXPYSElVtD7T5m ib8x1h77b+cs4UgsKGWXeWo4JhJYrjCjoDnLs18oCeTE8CpmcPlV7SYWPxXedTMHx2hH0z pyJZgRsTbENIcrPAOfRfCJgD9pqVh2k= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-IBrt8wSlOUW-IabNN1aDlA-1; Mon, 29 Aug 2022 07:47:51 -0400 X-MC-Unique: IBrt8wSlOUW-IabNN1aDlA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6E688380673F; Mon, 29 Aug 2022 11:47:51 +0000 (UTC) Received: from localhost (unknown [10.39.193.155]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 100C6C15BBA; Mon, 29 Aug 2022 11:47:50 +0000 (UTC) From: Cornelia Huck To: Jason Gunthorpe , Alex Williamson , Eric Farman , kvm@vger.kernel.org, linux-s390@vger.kernel.org, Matthew Rosato Cc: Kevin Tian Subject: Re: [PATCH v2 1/3] vfio/pci: Split linux/vfio_pci_core.h In-Reply-To: <1-v2-1bd95d72f298+e0e-vfio_pci_priv_jgg@nvidia.com> Organization: Red Hat GmbH References: <1-v2-1bd95d72f298+e0e-vfio_pci_priv_jgg@nvidia.com> User-Agent: Notmuch/0.36 (https://notmuchmail.org) Date: Mon, 29 Aug 2022 13:47:49 +0200 Message-ID: <877d2rfeze.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Fri, Aug 26 2022, Jason Gunthorpe wrote: > The header in include/linux should have only the exported interface for > other vfio_pci module's to use. Internal definitions for vfio_pci.ko s/module's/modules/ > should be in a "priv" header along side the .c files. > > Move the internal declarations out of vfio_pci_core.h. They either move to > vfio_pci_priv.h or to the C file that is the only user. > > Reviewed-by: Kevin Tian > Signed-off-by: Jason Gunthorpe > --- > drivers/vfio/pci/vfio_pci.c | 2 +- > drivers/vfio/pci/vfio_pci_config.c | 2 +- > drivers/vfio/pci/vfio_pci_core.c | 19 +++- > drivers/vfio/pci/vfio_pci_igd.c | 2 +- > drivers/vfio/pci/vfio_pci_intrs.c | 16 +++- > drivers/vfio/pci/vfio_pci_priv.h | 106 +++++++++++++++++++++++ > drivers/vfio/pci/vfio_pci_rdwr.c | 2 +- > drivers/vfio/pci/vfio_pci_zdev.c | 2 +- > include/linux/vfio_pci_core.h | 134 +---------------------------- > 9 files changed, 145 insertions(+), 140 deletions(-) > create mode 100644 drivers/vfio/pci/vfio_pci_priv.h Reviewed-by: Cornelia Huck