From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 938673D3BA for ; Tue, 9 Jan 2024 19:31:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cQOLlmca" Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7bee9f626caso7750839f.0 for ; Tue, 09 Jan 2024 11:31:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1704828716; x=1705433516; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BX6WX/X3x+sI97fYVnBXml21yMAcf1vyq5kAEe0Em5I=; b=cQOLlmcaqUhwLAlPb+YoK3cpqG/tM8PhBonRBnB5rSFHDbv9gltx+ferLiG2ju6r9G iMPRslGBbDavGiQMV8dbOmz3cYbsLyFAhy/ICM4Y6nmP4tZmKAxZ8lRnwQQypWQ8XnlM 7d3Mi6ANWHBF7ByciB6j+Aeu8Lig//xPys6BE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704828716; x=1705433516; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BX6WX/X3x+sI97fYVnBXml21yMAcf1vyq5kAEe0Em5I=; b=R8D4QesS6FygNxPvVvKfzUhgkhQhzd58N/eJJu1j7p1hTzjxJu9VeF1wSH+wqVqBwV 0UEq+nNPyXMxbpBsMGYCxLJFf+qGxyJiJghA+coNJZYio9ZIuhnUpY04tNU1PAo2/sKZ heT+GTM5HBzxtPHfbclummE+m3WkHblod1Jnz2W0Y/93kXwPnjyXq0hp9jOGcTrqVO5q 1yxFU39vKXAkq82xsmbKKXC5G8LojALDjM1dMy1YdW7EW/Potm98KSx7cxK91gHQ4r0d Q8faJlgpOeZ7/oFluHhNvma+IDhjf8XeoGdkq3Z/Fel8D53EBQVrBeywHZdWkjYtIjQf xEKg== X-Gm-Message-State: AOJu0Yxk8TP9+70Xc7VNLPfRGBX9ntcKcM2/aIrbDbGp4frPOhJ94AwA U6zzGRg/+YPP3TSLvGBV0DCfXlYtHMK44w== X-Google-Smtp-Source: AGHT+IF17YouLb8dLiAWKBE/dIFNs+76nEgViYUyT37MYA3oOcuaMwflJbAwRKNo9bXNPVTnggdieA== X-Received: by 2002:a5d:804a:0:b0:7bc:207d:5178 with SMTP id b10-20020a5d804a000000b007bc207d5178mr10285797ior.2.1704828715769; Tue, 09 Jan 2024 11:31:55 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id dq33-20020a0566384d2100b0046dd0db4a14sm800066jab.99.2024.01.09.11.31.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jan 2024 11:31:55 -0800 (PST) Message-ID: <87b55a25-4288-4add-b2b3-0038ed41b08e@linuxfoundation.org> Date: Tue, 9 Jan 2024 12:31:53 -0700 Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v4 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR variable Content-Language: en-US To: Marcos Paulo de Souza , Joe Lawrence Cc: Shuah Khan , Jonathan Corbet , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, live-patching@vger.kernel.org, Shuah Khan References: <20231220-send-lp-kselftests-v4-0-3458ec1b1a38@suse.com> <20231220-send-lp-kselftests-v4-1-3458ec1b1a38@suse.com> <4fb169fd-393c-441e-b0f7-32a3777c1d11@linuxfoundation.org> <11c112df801008f6bc4b7813645d505388894e29.camel@suse.com> From: Shuah Khan In-Reply-To: <11c112df801008f6bc4b7813645d505388894e29.camel@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/8/24 10:13, Marcos Paulo de Souza wrote: > On Wed, 2024-01-03 at 15:09 -0700, Shuah Khan wrote: >> >> Copying source files and object files doesn't sound right. This isn't >> how the ksleftest installs work. Let's fix this. > > Hi Shuah, > > what do you think about the proposed solution? Could you please amend > the fix into the first patch if you think it's the right approach? > I would like to see a new revision of the patch series with the fix to the problem. I will pull this into a separate test branch for us all to test different scenarios. I would like to make sure the repo will stay clean after install in the case of when out of tree builds. Sorry I can't amend the patch as this isn't a trivial merge change. This change requires more testing. thanks, -- Shuah