From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Michael Ellerman Subject: Re: Linux 5.1-rc5 In-Reply-To: <20190502122128.GA2670@kroah.com> References: <20190415051919.GA31481@infradead.org> <20190502122128.GA2670@kroah.com> Date: Fri, 03 May 2019 23:31:48 +1000 Message-ID: <87ef5fy88r.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Archive: To: Greg KH , Linus Torvalds Cc: Christoph Hellwig , Martin Schwidefsky , linuxppc-dev@lists.ozlabs.org, Linux List Kernel Mailing , linux-s390 List-ID: Greg KH writes: > On Mon, Apr 15, 2019 at 09:17:10AM -0700, Linus Torvalds wrote: >> On Sun, Apr 14, 2019 at 10:19 PM Christoph Hellwig wrote: >> > >> > Can we please have the page refcount overflow fixes out on the list >> > for review, even if it is after the fact? >> >> They were actually on a list for review long before the fact, but it >> was the security mailing list. The issue actually got discussed back >> in January along with early versions of the patches, but then we >> dropped the ball because it just wasn't on anybody's radar and it got >> resurrected late March. Willy wrote a rather bigger patch-series, and >> review of that is what then resulted in those commits. So they may >> look recent, but that's just because the original patches got >> seriously edited down and rewritten. >> >> That said, powerpc and s390 should at least look at maybe adding a >> check for the page ref in their gup paths too. Powerpc has the special >> gup_hugepte() case, and s390 has its own version of gup entirely. I >> was actually hoping the s390 guys would look at using the generic gup >> code. >> >> I ruthlessly also entirely ignored MIPS, SH and sparc, since they seem >> largely irrelevant, partly since even theoretically this whole issue >> needs a _lot_ of memory. >> >> Michael, Martin, see commit 6b3a70773630 ("Merge branch 'page-refs' >> (page ref overflow)"). You may or may not really care. > > I've now queued these patches up for the next round of stable releases, > as some people seem to care about these. > > I didn't see any follow-on patches for s390 or ppc64 hit the tree for > these changes, am I just missing them and should also queue up a few > more to handle this issue on those platforms? No you haven't missed them for powerpc. It's on my list. cheers