From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Michael Ellerman Subject: Re: [PATCH seccomp 3/8] powerpc: Enable seccomp architecture tracking In-Reply-To: References: <4ec2970fcc819eb4d5dac2bd35233ccdadfda845.1604410035.git.yifeifz2@illinois.edu> <87wnz1to9n.fsf@mpe.ellerman.id.au> Date: Thu, 05 Nov 2020 22:26:44 +1100 Message-ID: <87ft5ot56z.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain List-ID: To: YiFei Zhu Cc: Linux Containers , linux-sh@vger.kernel.org, Tobin Feldman-Fitzthum , Hubertus Franke , Jack Chen , linux-riscv@lists.infradead.org, Andrea Arcangeli , linux-s390@vger.kernel.org, YiFei Zhu , linux-csky@vger.kernel.org, Tianyin Xu , linux-xtensa@linux-xtensa.org, Kees Cook , Jann Horn , Valentin Rothberg , Aleksa Sarai , Josep Torrellas , Will Drewry , linux-parisc@vger.kernel.org, kernel list , Andy Lutomirski , Dimitrios Skarlatos , David Laight , Giuseppe Scrivano , linuxppc-dev@lists.ozlabs.org, Tycho Andersen YiFei Zhu writes: > On Wed, Nov 4, 2020 at 4:22 AM Michael Ellerman wrote: >> > +#ifdef __LITTLE_ENDIAN__ >> >> As Kees mentioned this should (must?!) match the configured endian. >> >> But I think it would still be better to use the CONFIG symbol, which is >> CONFIG_CPU_LITTLE_ENDIAN. > > My attempt here is to be consistent with asm/syscall.h > syscall_get_arch [1]. Would it make sense to change that to > CONFIG_CPU_LITTLE_ENDIAN then? > > [1] https://elixir.bootlin.com/linux/latest/source/arch/powerpc/include/asm/syscall.h#L116 Looking across the tree with have thousands of usages of __LITTLE_ENDIAN__, so it's probably not worth converting to CONFIG_CPU_LITTLE_ENDIAN. >> > +# define SECCOMP_ARCH_NATIVE (AUDIT_ARCH_PPC64 | __SECCOMP_ARCH_LE) >> >> You use __SECCOMP_ARCH_LE there, but previously you only defined >> __SECCOMP_ARCH_LE_BIT. >> >> Is there some magic somewhere that defines __SECCOMP_ARCH_LE based on >> __SECCOMP_ARCH_LE_BIT ? > > Oops, my bad here. OK :) >> > +# define SECCOMP_ARCH_NATIVE_NR NR_syscalls >> > +# define SECCOMP_ARCH_NATIVE_NAME "ppc64" >> >> What's the name used for? > > This is used in the last patch in this series to report in procfs the > name of each architecture tracked by the bitmap cache. OK, yeah I think it would be better if the matched the uname -m values. >> Usually we use "ppc64" for 64-bit big endian and "ppc64le" for 64-bit >> little endian. >> >> And usually we use "ppc" for 32-bit. > > Ok. cheers