From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ACE83B5E07 for ; Tue, 7 Jul 2026 09:38:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783417125; cv=none; b=Gxj2PC5kT0EoMhkJewDRnbJ8e+p7sICgE5oYetTTpIzj+AQo9Z0zzwP1LKDmmvKMFvyM/cDx5hMxgfzHFOSnNP7Vm0UNL1kFX5SWPNTzU4L/1vRCtrw+CduCtDrNHMiOXKJMyoLvkj8a9FZRgB9nwwA/Bp8MLdBWhdin6JfC0IQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783417125; c=relaxed/simple; bh=qs15xkvATvN/mDe6CAgVPsmas5SJo5U6Ae43ixBF52c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=mHlzGBBXaH4Hw+tbd/EnZK2bRmS2IGybCV0SV0kMhh5P+RnKvPebmGDESMiJXl2S58olgTDFkJR1bE+bu2MMhcnSb3LGD+s0l21QbhWzXCjATy0KFxANEYsya6N8DHCBwxFAxDxTnUn2S1RElddqTWfbmyzVs4zf2Yv/K0EYRCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QIORWAzm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QIORWAzm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783417119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5asutad2zaIsOememTKrTQLyi4rB2Il2HvaVX8/4Ogk=; b=QIORWAzmLE0j3edg2L8gcsRXTjquOWMEjk/Rp5yyLBMemzzpiGDmBP/kP4TdHUKwLRcJ2F HMgjYU7gVfrbbSiq8m0RXUfOIKhwBC2hbYSiYCvB+pfBXCEQU+50pFyW7fIONIORB9oppO 8fdFhpAhpp0qiJfaxByJPW78wMD7m+c= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-426-BK87US3POI-YfYWy3FrkAA-1; Tue, 07 Jul 2026 05:38:37 -0400 X-MC-Unique: BK87US3POI-YfYWy3FrkAA-1 X-Mimecast-MFC-AGG-ID: BK87US3POI-YfYWy3FrkAA_1783417116 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 09DBA180130E; Tue, 7 Jul 2026 09:38:36 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 21D2B1955F71; Tue, 7 Jul 2026 09:38:34 +0000 (UTC) From: Cornelia Huck To: Harald Freudenberger , richard.henderson@linaro.org, iii@linux.ibm.com, david@kernel.org, thuth@redhat.com, berrange@redhat.com Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, linux-s390@vger.kernel.org, dengler@linux.ibm.com, borntraeger@linux.ibm.com, fcallies@linux.ibm.com Subject: Re: [PATCH v10 00/21] target/s390x: Extend qemu CPACF support In-Reply-To: <20260706094317.17032-1-freude@linux.ibm.com> Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Avril Crosse O'Flaherty" References: <20260706094317.17032-1-freude@linux.ibm.com> User-Agent: Notmuch/0.40 (https://notmuchmail.org) Date: Tue, 07 Jul 2026 11:38:32 +0200 Message-ID: <87jyr7jg13.fsf@redhat.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Mon, Jul 06 2026, Harald Freudenberger wrote: > This patch series extends the s390 qemu CPACF support to be able to > run a subset of the CPACF instruction cross platform. There have been > requests on the kernel crypto mailing list about a way to test > s390 specific crypto implementations. For example a way to test > s390 CPACF exploitation code like the s390_aes.ko kernel module. > > So here now is a set of patches verified on x86 and s390 which > over (slow but working) support for a subset of the subfunctions of > some of the CPACF instructions. Hi, I wanted to pick this, but unfortunately, there are some problems with it, as spotted by checkpatch (sadly, I did not see this earlier, and softfreeze is upon us...) - Licensing information: new files (e.g. cpacf.h) must use an SPDX identifier instead of licence boilerplate text - this needs to be fixed - some files are using tabs instead of spaces in some places - there are also some other moans (less important), but you may want to look at them anyway (the long lines are not really a problem) Cornelia