From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:34410 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394039AbgLKJw4 (ORCPT ); Fri, 11 Dec 2020 04:52:56 -0500 From: Jani Nikula Subject: Re: [Intel-gfx] [patch 13/30] drm/i915/lpe_audio: Remove pointless irq_to_desc() usage In-Reply-To: References: <20201210192536.118432146@linutronix.de> <20201210194043.862572239@linutronix.de> Date: Fri, 11 Dec 2020 11:51:57 +0200 Message-ID: <87zh2k7jr6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit List-ID: To: Ville =?utf-8?B?U3lyasOkbMOk?= , Thomas Gleixner Cc: Mark Rutland , Karthikeyan Mitran , Peter Zijlstra , Catalin Marinas , Linus Walleij , dri-devel@lists.freedesktop.org, Chris Wilson , "James E.J. Bottomley" , Russell King , afzal mohammed , Boris Ostrovsky , Rob Herring , Lorenzo Pieralisi , Dave Jiang , Leon Romanovsky , linux-rdma@vger.kernel.org, Marc Zyngier , Helge Deller , Michal Simek , Christian Borntraeger , linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, intel-gfx@lists.freedesktop.org, Wambui Karuga , Allen Hubbe , Will Deacon , linux-s390@vger.kernel.org, Heiko Carstens , linux-gpio@vger.kernel.org, Stefano Stabellini , Jakub Kicinski , Bjorn Helgaas , Lee Jones , linux-arm-kernel@lists.infradead.org, Juergen Gross , David Airlie , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Hou Zhiqiang , LKML , Tariq Toukan , Jon Mason , linux-ntb@googlegroups.com, Saeed Mahameed , "David S. Miller" On Thu, 10 Dec 2020, Ville Syrjälä wrote: > On Thu, Dec 10, 2020 at 08:25:49PM +0100, Thomas Gleixner wrote: >> Nothing uses the result and nothing should ever use it in driver code. >> >> Signed-off-by: Thomas Gleixner >> Cc: Jani Nikula >> Cc: Joonas Lahtinen >> Cc: Rodrigo Vivi >> Cc: David Airlie >> Cc: Daniel Vetter >> Cc: Pankaj Bharadiya >> Cc: Chris Wilson >> Cc: Wambui Karuga >> Cc: intel-gfx@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org > > Reviewed-by: Ville Syrjälä Thomas, I presume you want to merge this series as a whole. Acked-by: Jani Nikula for merging via whichever tree makes most sense. Please let us know if you want us to pick this up via drm-intel instead. > >> --- >> drivers/gpu/drm/i915/display/intel_lpe_audio.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> --- a/drivers/gpu/drm/i915/display/intel_lpe_audio.c >> +++ b/drivers/gpu/drm/i915/display/intel_lpe_audio.c >> @@ -297,13 +297,9 @@ int intel_lpe_audio_init(struct drm_i915 >> */ >> void intel_lpe_audio_teardown(struct drm_i915_private *dev_priv) >> { >> - struct irq_desc *desc; >> - >> if (!HAS_LPE_AUDIO(dev_priv)) >> return; >> >> - desc = irq_to_desc(dev_priv->lpe_audio.irq); >> - >> lpe_audio_platdev_destroy(dev_priv); >> >> irq_free_desc(dev_priv->lpe_audio.irq); >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center