From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.110.172]:58144 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727724AbfJHINM (ORCPT ); Tue, 8 Oct 2019 04:13:12 -0400 Subject: Re: [PATCH V4 2/2] mm/pgtable/debug: Add test validating architecture page table helpers References: <1570427124-21887-1-git-send-email-anshuman.khandual@arm.com> <1570427124-21887-3-git-send-email-anshuman.khandual@arm.com> <20191007130617.GB56546@gmail.com> <20191007132607.4q537nauwfn5thol@box> <20191007135158.GA36360@gmail.com> <20191007140058.um5g44rvxyzyiref@box> From: Anshuman Khandual Message-ID: <881796fc-c35e-3790-a1ee-7031c6cdb38d@arm.com> Date: Tue, 8 Oct 2019 13:43:22 +0530 MIME-Version: 1.0 In-Reply-To: <20191007140058.um5g44rvxyzyiref@box> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: "Kirill A. Shutemov" , Ingo Molnar Cc: linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , Gerald Schaefer , Christophe Leroy , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org On 10/07/2019 07:30 PM, Kirill A. Shutemov wrote: > On Mon, Oct 07, 2019 at 03:51:58PM +0200, Ingo Molnar wrote: >> >> * Kirill A. Shutemov wrote: >> >>> On Mon, Oct 07, 2019 at 03:06:17PM +0200, Ingo Molnar wrote: >>>> >>>> * Anshuman Khandual wrote: >>>> >>>>> This adds a test module which will validate architecture page table helpers >>>>> and accessors regarding compliance with generic MM semantics expectations. >>>>> This will help various architectures in validating changes to the existing >>>>> page table helpers or addition of new ones. >>>>> >>>>> Test page table and memory pages creating it's entries at various level are >>>>> all allocated from system memory with required alignments. If memory pages >>>>> with required size and alignment could not be allocated, then all depending >>>>> individual tests are skipped. >>>> >>>>> diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h >>>>> index 52e5f5f2240d..b882792a3999 100644 >>>>> --- a/arch/x86/include/asm/pgtable_64_types.h >>>>> +++ b/arch/x86/include/asm/pgtable_64_types.h >>>>> @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void) >>>>> #define pgtable_l5_enabled() 0 >>>>> #endif /* CONFIG_X86_5LEVEL */ >>>>> >>>>> +#define mm_p4d_folded(mm) (!pgtable_l5_enabled()) >>>>> + >>>>> extern unsigned int pgdir_shift; >>>>> extern unsigned int ptrs_per_p4d; >>>> >>>> Any deep reason this has to be a macro instead of proper C? >>> >>> It's a way to override the generic mm_p4d_folded(). It can be rewritten >>> as inline function + define. Something like: >>> >>> #define mm_p4d_folded mm_p4d_folded >>> static inline bool mm_p4d_folded(struct mm_struct *mm) >>> { >>> return !pgtable_l5_enabled(); >>> } >>> >>> But I don't see much reason to be more verbose here than needed. >> >> C type checking? Documentation? Yeah, I know it's just a one-liner, but >> the principle of the death by a thousand cuts applies here. > > Okay, if you think it worth it. Anshuman, could you fix it up for the next > submission? Sure, will do. > > >> BTW., any reason this must be in the low level pgtable_64_types.h type >> header, instead of one of the API level header files? > > I defined it next pgtable_l5_enabled(). What is more appropriate place to > you? pgtable_64.h? Yeah, it makes sense. Needs to be moved to arch/x86/include/asm/pgtable_64.h as well ?