Re: [kvm-unit-tests PATCH v3 5/6] s390x: sclp: Add detection of alternate STFLE facilities

Janosch Frank
2026-04-22T12:39:03Z

On 4/21/26 13:31, Christoph Schlameuss wrote:
> From: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
>
> Detect availability of alternate STFLE interpretive execution facilities
> 1 and 2.
>
> Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> Co-developed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> ---
> lib/s390x/sclp.c | 5 +++++
> lib/s390x/sclp.h | 4 ++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/lib/s390x/sclp.c b/lib/s390x/sclp.c
> index ad2ba99ee1e1..d4e7eff66c31 100644
> --- a/lib/s390x/sclp.c
> +++ b/lib/s390x/sclp.c
> @@ -181,12 +181,17 @@ void sclp_facilities_setup(void)
> sclp_facilities.has_cmma = sclp_feat_check(116, SCLP_FEAT_116_BIT_CMMA);
> sclp_facilities.has_64bscao = sclp_feat_check(116, SCLP_FEAT_116_BIT_64BSCAO);
> sclp_facilities.has_esca = sclp_feat_check(116, SCLP_FEAT_116_BIT_ESCA);
> + sclp_facilities.has_astfleie1 = sclp_feat_check(116, SCLP_FEAT_116_BIT_ASTFLEIE1);
> sclp_facilities.has_ibs = sclp_feat_check(117, SCLP_FEAT_117_BIT_IBS);
> sclp_facilities.has_pfmfi = sclp_feat_check(117, SCLP_FEAT_117_BIT_PFMFI);
>
> if (read_info->offset_cpu <= 134)
> return;
> sclp_facilities.has_diag318 = sclp_feat_check(134, SCLP_FEAT_134_BIT_DIAG318);
> +
> + if (read_info->offset_cpu <= 139)
> + return;
> + sclp_facilities.has_astfleie2 = sclp_feat_check(139, SCLP_FEAT_139_BIT_ASTFLEIE2);
> }
>
> /* Perform service call. Return 0 on success, non-zero otherwise. */
> diff --git a/lib/s390x/sclp.h b/lib/s390x/sclp.h
> index 87af429b5798..eb574350d678 100644
> --- a/lib/s390x/sclp.h
> +++ b/lib/s390x/sclp.h
> @@ -129,9 +129,11 @@ struct sclp_facilities {
> uint64_t has_cmma : 1;
> uint64_t has_64bscao : 1;
> uint64_t has_esca : 1;
> + uint64_t has_astfleie1 : 1;

I don't think that we need to order this by appearance in read info.
The constants seem fine so we're only arguing about technicalities.