From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68183EB64D8 for ; Tue, 13 Jun 2023 17:01:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234693AbjFMRBK (ORCPT ); Tue, 13 Jun 2023 13:01:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234648AbjFMRBJ (ORCPT ); Tue, 13 Jun 2023 13:01:09 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 472FB123 for ; Tue, 13 Jun 2023 10:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686675624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N+LdwBzt0uYokh007O/q+HMXZaTU5MnHMEEMsHFG/3Y=; b=b5QXc1UDtXhLUrUBT8VP+aRWSn1WZxFm8SinST+aDCPbgy4goOCMSUKrUmj2ayxYc2mHy8 +tU7+MY0tq9QL6bVA0IhfA1GZvbkzKmJs7eQ0a6dRYmGbgNbbFKZ+wNri2PUsbdY+rAeSO gs1DA+H3Gg5UFGbHLSq+WUA03T9ut+M= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-114-7L7TFfGEN8atjk3aPg32SQ-1; Tue, 13 Jun 2023 13:00:22 -0400 X-MC-Unique: 7L7TFfGEN8atjk3aPg32SQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f7e7cfcae4so37106905e9.1 for ; Tue, 13 Jun 2023 10:00:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686675621; x=1689267621; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N+LdwBzt0uYokh007O/q+HMXZaTU5MnHMEEMsHFG/3Y=; b=iXWluEFNj8nNrq12IzUKMn24/1WVxTtWiL9I9TpHv3bzm+RJlegDgVCrwIwJy+QvYj ik5MYbTLvwnFCsBdfuMFp+WHTIb3eHG/e7Wj7fMdZCNyXeeyAb0kwUKkkDmsrSmao733 T3ewc2QPSfO/1YJm2oEbwFXHRI420Yx+BXPWcx66RJLT6+o83huAxq11dqRFzNYUeL2a mSDyUtZdbcZXvNYKNdiDaiK7Lo0KZtokXIAfIh7tqk1z0aK/4vTYFG3i5ZO8e6YxN2NZ EzzBVwSk920EfVIO8xyksncphwg3fHqny5MC6PWC8RrhzZff/mRkj8pB8HLd5Y40jSQ7 UwYw== X-Gm-Message-State: AC+VfDzSa1thp5wVl4BcgLhNEyczcZa+KiK+BSS5s/Te4itKqutTDYZ3 ROF96Q3D7J9jkY6dRH/J/603j/S6Xt0eWYs+8A01qV2gXdi9FCiYzMUYSsWT3YY0zYyhNLs5PwC T4m3DWhkTgfjhBJFqB4ffkw== X-Received: by 2002:a05:600c:2041:b0:3f8:d0e7:daed with SMTP id p1-20020a05600c204100b003f8d0e7daedmr1651684wmg.19.1686675620852; Tue, 13 Jun 2023 10:00:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5DqYDEwXY1aS+T8oevGZM1GGzvu3C6CrpD97OsPgkk4IOclN0QORetIFLX25l+OyKcdC2cGA== X-Received: by 2002:a05:600c:2041:b0:3f8:d0e7:daed with SMTP id p1-20020a05600c204100b003f8d0e7daedmr1651659wmg.19.1686675620442; Tue, 13 Jun 2023 10:00:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c710:ff00:1a06:80f:733a:e8c6? (p200300cbc710ff001a06080f733ae8c6.dip0.t-ipconnect.de. [2003:cb:c710:ff00:1a06:80f:733a:e8c6]) by smtp.gmail.com with ESMTPSA id d17-20020adffbd1000000b0030fb4b55c13sm9792662wrs.96.2023.06.13.10.00.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 10:00:19 -0700 (PDT) Message-ID: <8a053da2-0f26-82ca-f437-9b9de11d4584@redhat.com> Date: Tue, 13 Jun 2023 19:00:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v9 02/42] mm: Move pte/pmd_mkwrite() callers with no VMA to _novma() Content-Language: en-US To: "Edgecombe, Rick P" , "rppt@kernel.org" Cc: "akpm@linux-foundation.org" , "tglx@linutronix.de" , "linux-arch@vger.kernel.org" , "kcc@google.com" , "Lutomirski, Andy" , "nadav.amit@gmail.com" , "kirill.shutemov@linux.intel.com" , "Schimpe, Christina" , "linux-s390@vger.kernel.org" , "Torvalds, Linus" , "peterz@infradead.org" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "jannh@google.com" , "dethoma@microsoft.com" , "broonie@kernel.org" , "mike.kravetz@oracle.com" , "pavel@ucw.cz" , "bp@alien8.de" , "rdunlap@infradead.org" , "linux-api@vger.kernel.org" , "john.allen@amd.com" , "arnd@arndb.de" , "jamorris@linux.microsoft.com" , "bsingharora@gmail.com" , "x86@kernel.org" , "oleg@redhat.com" , "fweimer@redhat.com" , "keescook@chromium.org" , "gorcunov@gmail.com" , "andrew.cooper3@citrix.com" , "xen-devel@lists.xenproject.org" , "hpa@zytor.com" , "mingo@redhat.com" , "szabolcs.nagy@arm.com" , "hjl.tools@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "debug@rivosinc.com" , "linux-mm@kvack.org" , "Syromiatnikov, Eugene" , "Yang, Weijiang" , "linux-doc@vger.kernel.org" , "dave.hansen@linux.intel.com" , "Eranian, Stephane" References: <20230613001108.3040476-1-rick.p.edgecombe@intel.com> <20230613001108.3040476-3-rick.p.edgecombe@intel.com> <20230613074428.GS52412@kernel.org> <21b0342854b067c241206f422bc5b3254b43c7f5.camel@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <21b0342854b067c241206f422bc5b3254b43c7f5.camel@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 13.06.23 18:19, Edgecombe, Rick P wrote: > On Tue, 2023-06-13 at 10:44 +0300, Mike Rapoport wrote: >>> Previous patches have done the first step, so next move the callers >>> that >>> don't have a VMA to pte_mkwrite_novma(). Also do the same for >> >> I hear x86 maintainers asking to drop "previous patches" ;-) >> >> Maybe >> This is the second step of the conversion that moves the callers ... > > Really? I've not heard that. Just a strong aversion to "this patch". > I've got feedback to say "previous patches" and not "the last patch" so > it doesn't get stale. I guess it could be "previous changes". Talking about patches make sense when discussing literal patches sent to the mailing list. In the git log, it's commit, and "future commits" or "follow-up work". Yes, we use "patches" all of the time in commit logs, especially when we include the cover letter in the commit message (as done frequently in the -mm tree). -- Cheers, David / dhildenb