Re: [PATCH net-next v2] net/smc: Reduce overflow of smc clcsock listen queue

Karsten Graul
2022-01-05T19:13:34Z

On 05/01/2022 16:06, D. Wythe wrote:
> LGTM. Fallback makes the restrictions on SMC dangling
> connections more meaningful to me, compared to dropping them.
>
> Overall, i see there are two scenario.
>
> 1. Drop the overflow connections limited by userspace application
> accept.
>
> 2. Fallback the overflow connections limited by the heavy process of
> current SMC handshake. ( We can also control its behavior through
> sysctl.)
>

I vote for (2) which makes the behavior from user space applications point of view more like TCP.

One comment to sysctl: our current approach is to add new switches to the existing
netlink interface which can be used with the smc-tools package (or own implementations of course).
Is this prereq problematic in your environment?
We tried to avoid more sysctls and the netlink interface keeps use more flexible.