Re: [PATCH net] net/smc: Remove validation of reserved bits in CLC Decline message

[Mahanta Jambigi <mjambigi@linux.ibm.com>]

On 02/09/25 9:38 am, Dust Li wrote:
>>>
>>> Did I miss something ?
>>
>> If you refer to struct *smc_clc_msg_hdr* in smc_clc.h file, typev1 member
>> represents bits 4 & 5 at offset 7. If we compare it with the CLC Decline
>> message header, it represents one of the reserved(5-7 bits) at offset 7. You
>> can refer to below link for reserved bits.
>>
>> https://datatracker.ietf.org/doc/html/rfc7609#page-105
> 
> Oh, I see, thanks! The patch looks good to me.
> 
> 
> BTW, I checked the rfc7609 and SMCv2.1 spec:
> https://www.ibm.com/support/pages/system/files/inline-files/IBM%20Shared%20Memory%20Communications%20Version%202.1_0.pdf
> 
> I think the name type1/type2 in smc_clc_msg_hdr is confusing, as it doesn't sync
> with the spec for decline message.

I agree with you. We can address them in future. Since they are part of
reserved bits, we can ignore parsing them for now. May I add your R-b
for this patch?

> 
> Best regards,
> Dust
> 
>