RE: [PATCH v3 00/15] iommu: Retire bus_set_iommu()

Tian, Kevin
2022-07-21T07:18:08Z

> From: Robin Murphy <robin.murphy@arm.com>
> Sent: Friday, July 15, 2022 9:13 PM
>
> On 2022-07-05 18:08, Robin Murphy wrote:
> > v2: https://lore.kernel.org/linux-
> iommu/cover.1650890638.git.robin.murphy@arm.com/
> >
> > Hi all,
> >
> > Here's v3, now with working x86! Having finally made sense of how I
> > broke Intel, I've given AMD the same fix by inspection. I'm still not
> > 100% sure about s390, but it looks like it should probably be OK since
> > it seems to register an IOMMU instance for each PCI device (?!) before
> > disappearing into PCI hotplug code, wherein I assume we should never see
> > a PCI device appear without its IOMMU already registered.
> >
> > Otherwise, the only other updates are hooking up the new host1x context
> > bus (noting that it now takes all of 4 lines to support a whole new bus,
> > yay!), and a slight tweak to make sure we keep rejecting registration of
> > conflicting iommu_ops rather than needlessly change that just yet.
>
> FWIW I've prepared v4, including Matt's s390 patch and some nice extra
> cleanups thanks to Kevin's suggestions, but have now decided to wait to
> rebase and send it after the upcoming merge window. If anyone's
> interested in the meantime, there's a preliminary branch here:
>
> https://gitlab.arm.com/linux-arm/linux-rm/-/commits/bus-set-iommu-v4
>
> (temporarily including the host1x patch from -next to avoid breakage on
> arm64 as well)
>

This looks good to me.