Re: [PATCH v3 03/15] iommu: Always register bus notifiers

Baolu Lu
2022-07-06T01:53:48Z

On 2022/7/6 01:08, Robin Murphy wrote:
> /*
> * Use a function instead of an array here because the domain-type is a
> * bit-field, so an array would waste memory.
> @@ -152,6 +172,10 @@ static int __init iommu_subsys_init(void)
> (iommu_cmd_line & IOMMU_CMD_LINE_STRICT) ?
> "(set via kernel command line)" : "");
>
> + /* If the system is so broken that this fails, it will WARN anyway */

Can you please elaborate a bit on this? iommu_bus_init() still return
errors.

> + for (int i = 0; i < ARRAY_SIZE(iommu_buses); i++)
> + iommu_bus_init(iommu_buses[i]);
> +
> return 0;

Best regards,
baolu