From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF66C433FE for ; Tue, 17 May 2022 08:29:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238377AbiEQI3k (ORCPT ); Tue, 17 May 2022 04:29:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238688AbiEQI3k (ORCPT ); Tue, 17 May 2022 04:29:40 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19856340CB; Tue, 17 May 2022 01:29:39 -0700 (PDT) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24H8NfUV017986; Tue, 17 May 2022 08:29:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=ohaMtG4Pa9XFmR1kG+EPioYheQB2aWO7iHx9NafltRM=; b=ZAcxoCdwZ4+ovcxM6vbmxUWPGdZu3HtpEcQW7XM8mj0ife9/zUzAWXrqsgbWALuPW9ad QGa4XzVjJ5wnwo7aXXyeo6hABr0DB93PbVdoMy7Q1ZWPwApKGTu/QMslD8LY1vvac1ME /k1arg/VtV2pwA6QdY16Q6MMSpYyqY5u5TvXz2t0AencZeRpCys1zWpQeG2m0IbD7rwy bO+tG9JP+vuiblmGp4bsubhstBFTgo1C4e3AHScBpGFpNv0MibSu+Dzed5bOMhHZrVyC NJTt5Q3cS3xQsY9ofcMtlA4ZPW/3ZWOK3iT32Dk827ptXn/X+BEg0IRdKB8zKuj2DK6O yA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g485j840r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 May 2022 08:29:38 +0000 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24H8Pgwx026653; Tue, 17 May 2022 08:29:38 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g485j83yu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 May 2022 08:29:38 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24H8MJ7Y032762; Tue, 17 May 2022 08:29:35 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma02fra.de.ibm.com with ESMTP id 3g2428k3an-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 May 2022 08:29:35 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24H8TWi048169222 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 May 2022 08:29:32 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 317F2A404D; Tue, 17 May 2022 08:29:32 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D7D48A4040; Tue, 17 May 2022 08:29:31 +0000 (GMT) Received: from [9.152.224.153] (unknown [9.152.224.153]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 17 May 2022 08:29:31 +0000 (GMT) Message-ID: <8c852bcd-6b42-4b54-d3ff-5d63a389b05d@linux.ibm.com> Date: Tue, 17 May 2022 10:29:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [kvm-unit-tests PATCH 3/6] s390x: uv-host: Test uv immediate parameter Content-Language: en-US To: Janosch Frank , kvm390 mailing list Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, imbrenda@linux.ibm.com, thuth@redhat.com, nrb@linux.ibm.com, scgl@linux.ibm.com References: <20220513095017.16301-1-frankja@linux.ibm.com> <20220513095017.16301-4-frankja@linux.ibm.com> From: Steffen Eiden Organization: IBM In-Reply-To: <20220513095017.16301-4-frankja@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: sGuXd8R0Q0RSESWTclAIHHJ6wV5p3SkG X-Proofpoint-ORIG-GUID: BMOz1Bq_aD0i8H5zOADQR4gjOC9nwW8d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-17_01,2022-05-16_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 spamscore=0 suspectscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 mlxscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205170048 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org Hey Janosch, On 5/13/22 11:50, Janosch Frank wrote: > Let's check if we get a specification PGM exception if we set a > non-zero i3 when doing a UV call. > > Signed-off-by: Janosch Frank > --- > s390x/uv-host.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/s390x/uv-host.c b/s390x/uv-host.c > index f846fc42..fcb82d24 100644 > --- a/s390x/uv-host.c > +++ b/s390x/uv-host.c > @@ -64,6 +64,28 @@ static struct cmd_list cmds[] = { > { NULL, 0, 0 }, > }; > > +static void test_i3(void) > +{ > + struct uv_cb_header uvcb = { > + .cmd = UVC_CMD_INIT_UV, > + .len = sizeof(struct uv_cb_init), > + }; > + unsigned long r1 = 0; Did you forgot 'r2' or is it missing for a reason? > + int cc; > + > + report_prefix_push("i3"); > + expect_pgm_int(); > + asm volatile( > + "0: .insn rrf,0xB9A40000,%[r1],%[r2],4,2\n" > + " ipm %[cc]\n" > + " srl %[cc],28\n" > + : [cc] "=d" (cc) > + : [r1] "a" (r1), [r2] "a" (&uvcb) > + : "memory", "cc"); > + check_pgm_int_code(PGM_INT_CODE_SPECIFICATION); > + report_prefix_pop(); > +} > + > static void test_priv(void) > { > struct uv_cb_header uvcb = {}; > @@ -585,6 +607,7 @@ int main(void) > goto done; > } > > + test_i3(); > test_priv(); > test_invalid(); > test_uv_uninitialized();