From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF2EC6FD1D for ; Fri, 17 Mar 2023 14:12:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230259AbjCQOMZ (ORCPT ); Fri, 17 Mar 2023 10:12:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230035AbjCQOMZ (ORCPT ); Fri, 17 Mar 2023 10:12:25 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7353260AAC for ; Fri, 17 Mar 2023 07:11:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679062300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/idMOlH3j3khBngSypGuD3NSbDuaGpvt2I83Bzbdzhg=; b=bmwnsG0yRLH9SbyBEpGDgtaeR05IBLHGjrMH01Be4Lj/+i/Nn+l6HSiXbfvFceBWaP38oW M5+0zYOQDdH2bcLMLxvGl2CPxnXM1m9GdejVE44j7DOf0eOnE9i0QMelDIz0ELMiHcISmu kpfnE3E/+3syOHYW2LAraG2tHjuKMtI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-E68aItogPamf1DTdK928qQ-1; Fri, 17 Mar 2023 10:11:39 -0400 X-MC-Unique: E68aItogPamf1DTdK928qQ-1 Received: by mail-wr1-f72.google.com with SMTP id p1-20020a5d6381000000b002cea6b2d5a9so843008wru.14 for ; Fri, 17 Mar 2023 07:11:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679062297; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/idMOlH3j3khBngSypGuD3NSbDuaGpvt2I83Bzbdzhg=; b=viVWGNwiFBl2Qpen9Sv/8MA5nNT0oxZCKM3BglXbVeb3QOeLF1w+KgmAQwblvm6ZuE qKXVRuHbW5YMeNZfB59/uSAwqEsU1nmTi25CcnPMwFuq9at/qw9vJ5hqdHXoAg+CNy6k Ln75xWpIBGHMNxG+y0MCSE93lyIOp691kCrnLR+8QBiUzB9lbBzvP0hIE4TP6+PuS9Q4 HJVVvQ+naNmaViibnVrH7VKvoIefg7cX+Iwu3ooqVE/A8HQZTb8PslkThk1oa/Hav/qz viSU7vYimurLGXb/rze6WxXFsb8qXjCjic+11lfSeVOYBENZs0H7TPXR6tgS0oWfMrrf 4OFg== X-Gm-Message-State: AO0yUKWO0e4BbIxABDcnvN3q6x9w41VlQ6mdm4v9LnurS2+ww4rIpnxo glZ3T58ahHNua9jZ0BLnkDnzHcqaC+ckEpAiQ8p0f+7skXkh0e3mIibC+Sn5IN3tOOygeDqY8Av v7rGA9MyUfpbNNmVaclEw3A== X-Received: by 2002:adf:ee82:0:b0:2c9:b9bf:e20c with SMTP id b2-20020adfee82000000b002c9b9bfe20cmr2446404wro.2.1679062297777; Fri, 17 Mar 2023 07:11:37 -0700 (PDT) X-Google-Smtp-Source: AK7set8VV5hpf0OyaSrG3QwT/NFHugVc8teY0e6S4hDgw5s/BMbRRrMTQif6dAKPo0QEL2ukYcMVSw== X-Received: by 2002:adf:ee82:0:b0:2c9:b9bf:e20c with SMTP id b2-20020adfee82000000b002c9b9bfe20cmr2446387wro.2.1679062297542; Fri, 17 Mar 2023 07:11:37 -0700 (PDT) Received: from [192.168.0.3] (ip-109-43-176-33.web.vodafone.de. [109.43.176.33]) by smtp.gmail.com with ESMTPSA id n2-20020adffe02000000b002cfeffb442bsm2054306wrr.57.2023.03.17.07.11.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Mar 2023 07:11:36 -0700 (PDT) Message-ID: <8deaddfe-dc69-ec3c-4c8c-a76ee17e6513@redhat.com> Date: Fri, 17 Mar 2023 15:11:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [kvm-unit-tests PATCH v3 3/3] s390x/spec_ex: Add test of EXECUTE with odd target address Content-Language: en-US From: Thomas Huth To: Nina Schoetterl-Glausch , Janosch Frank , Claudio Imbrenda Cc: David Hildenbrand , kvm@vger.kernel.org, linux-s390@vger.kernel.org, Ilya Leoshkevich References: <20230315155445.1688249-1-nsg@linux.ibm.com> <20230315155445.1688249-4-nsg@linux.ibm.com> <86aa2246-07ff-8fb9-ad97-3b68e8b8f109@redhat.com> In-Reply-To: <86aa2246-07ff-8fb9-ad97-3b68e8b8f109@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 17/03/2023 15.09, Thomas Huth wrote: > On 15/03/2023 16.54, Nina Schoetterl-Glausch wrote: >> The EXECUTE instruction executes the instruction at the given target >> address. This address must be halfword aligned, otherwise a >> specification exception occurs. >> Add a test for this. >> >> Signed-off-by: Nina Schoetterl-Glausch >> --- >>   s390x/spec_ex.c | 25 +++++++++++++++++++++++++ >>   1 file changed, 25 insertions(+) >> >> diff --git a/s390x/spec_ex.c b/s390x/spec_ex.c >> index 83b8c58e..5fa05dba 100644 >> --- a/s390x/spec_ex.c >> +++ b/s390x/spec_ex.c >> @@ -177,6 +177,30 @@ static int short_psw_bit_12_is_0(void) >>       return 0; >>   } >> +static int odd_ex_target(void) >> +{ >> +    uint64_t pre_target_addr; >> +    int to = 0, from = 0x0dd; >> + >> +    asm volatile ( ".pushsection .text.ex_odd\n" >> +        "    .balign    2\n" >> +        "pre_odd_ex_target:\n" >> +        "    . = . + 1\n" >> +        "    lr    %[to],%[from]\n" >> +        "    .popsection\n" >> + >> +        "    larl    %[pre_target_addr],pre_odd_ex_target\n" >> +        "    ex    0,1(%[pre_target_addr])\n" >> +        : [pre_target_addr] "=&a" (pre_target_addr), >> +          [to] "+d" (to) >> +        : [from] "d" (from) >> +    ); >> + >> +    assert((pre_target_addr + 1) & 1); >> +    report(to != from, "did not perform ex with odd target"); >> +    return 0; >> +} > > Can this be triggered with KVM, or is this just a test for TCG? With "triggered" I mean: Can this cause an interception in KVM? Thomas