From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8583C001E0 for ; Tue, 15 Aug 2023 00:35:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233389AbjHOAer (ORCPT ); Mon, 14 Aug 2023 20:34:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233372AbjHOAeS (ORCPT ); Mon, 14 Aug 2023 20:34:18 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FEDB93; Mon, 14 Aug 2023 17:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692059657; x=1723595657; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=VSM1w+2GQF5FWr9+uAkx0UUWSnoPqxj5esYUGnBEoIA=; b=kQl7s4CJiq0bR2DE8WbtUGPY2VZnHUCuVJ3Mxll4b9nehEZLO2p+/Jsh P0triNYETL+GIm6EfI2YuK5bXrBsoknFqNTsLzKTKZj38TCQzgwVL+X8s IsTgp8M/dCFf9cFl7HhPCh8ckSDD4tLJbE5qzy+GKUTYQ57A7XZ6mtvBp Me/9OFWU6C71caaKvc1dyK/Eb5q3oewZaaTI3Hk/vf+pq2W77ByPtdaI9 OTI6jID1GxrP6KE0mMYeV1mLtOBN4Qh+F7GLKr2n8XnpBn1C9szJoFBxd hj5dWSNqge4zfTQ/DzXxARBupcIDo2e2oX1G4yhKsvgf86AvliwqX1CFM g==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="374938114" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="374938114" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 17:34:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="823660205" X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; d="scan'208";a="823660205" Received: from wanglu5-mobl.ccr.corp.intel.com (HELO [10.254.215.149]) ([10.254.215.149]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 17:34:05 -0700 Message-ID: <8f3ce115-7489-640a-b1fb-a6fb6cfb1682@linux.intel.com> Date: Tue, 15 Aug 2023 08:34:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: baolu.lu@linux.intel.com, Andy Gross , Alim Akhtar , Bjorn Andersson , AngeloGioacchino Del Regno , Baolin Wang , Christophe Leroy , Gerald Schaefer , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Jonathan Hunter , Joerg Roedel , Kevin Tian , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Russell King , linuxppc-dev@lists.ozlabs.org, Matthias Brugger , Matthew Rosato , Michael Ellerman , Nicholas Piggin , Orson Zhai , Rob Clark , Robin Murphy , Samuel Holland , Thierry Reding , Krishna Reddy , Chen-Yu Tsai , Will Deacon , Yong Wu , Chunyan Zhang , Dmitry Osipenko , Marek Szyprowski , Nicolin Chen , Niklas Schnelle , Steven Price , Thierry Reding Subject: Re: [PATCH v6 07/25] iommu/mtk_iommu_v1: Implement an IDENTITY domain To: Jason Gunthorpe References: <7-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> <7b6b8118-813a-f4cd-1067-d209d2b40025@linux.intel.com> Content-Language: en-US From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 2023/8/14 22:34, Jason Gunthorpe wrote: >>> @@ -443,7 +459,7 @@ static int mtk_iommu_v1_create_mapping(struct device *dev, struct of_phandle_arg >>> static int mtk_iommu_v1_def_domain_type(struct device *dev) >>> { >>> - return IOMMU_DOMAIN_UNMANAGED; >>> + return IOMMU_DOMAIN_IDENTITY; >> def_domain_type can't be used for this purpose. But this seems to be a >> temporary code, as it will be removed in patch 09/25. > It looked OK when I checked it, mkt_v1 is really confusing what it > tries to do, but it should call probe_finalize and basically do the > same hacky thing as what UNMANAGED was trying to accomplish. > > Did you see something else? No. Best regards, baolu