Re: [PATCH 0/2] net/smc: Adjustments for two function implementations

Tony Lu
2024-01-02T08:44:54Z

On Tue, Jan 02, 2024 at 04:13:09PM +0800, Wen Gu wrote:
>
>
> On 2023/12/31 22:55, Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sun, 31 Dec 2023 15:48:45 +0100
> >
> > A few update suggestions were taken into account
> > from static source code analysis.
> >
> > Markus Elfring (2):
> > Return directly after a failed kzalloc() in smc_fill_gid_list()
> > Improve exception handling in smc_llc_cli_add_link_invite()
> >
> > net/smc/af_smc.c | 2 +-
> > net/smc/smc_llc.c | 15 +++++++--------
> > 2 files changed, 8 insertions(+), 9 deletions(-)
> >
> > --
> > 2.43.0
>
> Hi Markus. I see you want to fix the kfree(NULL) issues in these two patches.
>
> But I am wondering if this is necessary, since kfree() can handle NULL correctly.

I think the key point is that there are no necessary to call kfree() if
we can avoid this in normal logic.

Tony Lu