Re: [0/2] net/smc: Adjustments for two function implementations

Markus Elfring
2024-01-02T08:51:51Z

…
>> A few update suggestions were taken into account
>> from static source code analysis.
…
>>    Return directly after a failed kzalloc() in smc_fill_gid_list()
>>    Improve exception handling in smc_llc_cli_add_link_invite()
>>
>>   net/smc/af_smc.c  |  2 +-
>>   net/smc/smc_llc.c | 15 +++++++--------
>>   2 files changed, 8 insertions(+), 9 deletions(-)
…
> I see you want to fix the kfree(NULL) issues in these two patches.

I propose to avoid redundant function calls at various source code places.

> But I am wondering if this is necessary, since kfree() can handle NULL correctly.

Would you prefer only required data processing in affected function implementations?

Regards,
Markus