From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Date: Tue, 10 May 2016 10:36:40 +0200 Message-ID: <9651510.pg5Vmm8vKS@wuerfel> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <20160506123731.GA11959@yury-N73SV> <573190CF.6030408@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <573190CF.6030408@huawei.com> Sender: linux-doc-owner@vger.kernel.org List-Archive: List-Post: To: linux-arm-kernel@lists.infradead.org Cc: "Zhangjian (Bamvor)" , Yury Norov , linux-doc@vger.kernel.org, Andrew Pinski , catalin.marinas@arm.com, heiko.carstens@de.ibm.com, Hanjun Guo , joseph@codesourcery.com, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, "jijun (D)" , Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, agraf@suse.de, pinskia@gmail.com, klimov.linux@gmail.com, broonie@kernel.org, Nathan_Lynch@mentor.com, linux-kernel@vger.kernel.org, Andrew Pinski , schwidefsky@de.ibm.com, christoph.muellner@theobroma-systems.com List-ID: On Tuesday 10 May 2016 15:42:07 Zhangjian wrote: > On 2016/5/6 20:37, Yury Norov wrote: > > On Fri, May 06, 2016 at 08:16:48PM +0800, Zhangjian (Bamvor) wrote: > > > > AFAIR, here we don't shift offset, as it's 64-bit both in user- > > and kernel-space, > In your ilp32-2.22 branch, you wrapper mmap to mmap2 in which type of > offset is off_t. And off_t is 32bit in ilp32, correct? > "sysdeps/unix/sysv/linux/aarch64/ilp32/mmap64.c" > /* mmap is provided by mmap as they are the same. */ > void *__mmap (void *__addr, size_t __len, int __prot, > int __flags, int __fd, __off_t __offset) > { > void *result; > result = (void *) > INLINE_SYSCALL (mmap2, 6, __addr, > __len, __prot, __flags, __fd, __offset); > return result; > } __off_t should be 'long long' on new architectures, and map to __kernel_loff_t. Can you see how it is defined? Arnd