From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:7354 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbhAMNgA (ORCPT ); Wed, 13 Jan 2021 08:36:00 -0500 Subject: Re: [kvm-unit-tests PATCH v4 5/9] s390x: sie: Add SIE to lib References: <20210112132054.49756-1-frankja@linux.ibm.com> <20210112132054.49756-6-frankja@linux.ibm.com> <85cd46f1-fd09-752d-a85f-2a5907ee0802@redhat.com> From: Janosch Frank Message-ID: <9689f5a6-e1a8-d27f-d063-42006b8e7934@linux.ibm.com> Date: Wed, 13 Jan 2021 14:34:52 +0100 MIME-Version: 1.0 In-Reply-To: <85cd46f1-fd09-752d-a85f-2a5907ee0802@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-ID: To: Thomas Huth , kvm@vger.kernel.org Cc: david@redhat.com, borntraeger@de.ibm.com, imbrenda@linux.ibm.com, cohuck@redhat.com, linux-s390@vger.kernel.org On 1/13/21 1:44 PM, Thomas Huth wrote: > On 12/01/2021 14.20, Janosch Frank wrote: >> This commit adds the definition of the SIE control block struct and >> the assembly to execute SIE and save/restore guest registers. >> >> Signed-off-by: Janosch Frank >> --- >> lib/s390x/asm-offsets.c | 11 +++ >> lib/s390x/asm/arch_def.h | 9 ++ >> lib/s390x/interrupt.c | 7 ++ >> lib/s390x/sie.h | 197 +++++++++++++++++++++++++++++++++++++++ >> s390x/lib.S | 56 +++++++++++ >> 5 files changed, 280 insertions(+) >> create mode 100644 lib/s390x/sie.h > [...] >> diff --git a/lib/s390x/sie.h b/lib/s390x/sie.h >> new file mode 100644 >> index 0000000..66aa3b8 >> --- /dev/null >> +++ b/lib/s390x/sie.h >> @@ -0,0 +1,197 @@ >> +#ifndef SIE_H >> +#define SIE_H > > Add a SPDX license identifier at the top of the new file? Will do > > Apart from that looks ok to me. > > Acked-by: Thomas Huth Thanks!