From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"David S. Miller" <davem@davemloft.net>,
"Andreas Larsson" <andreas@gaisler.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Thomas Gleixner" <tglx@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
David Laight <david.laight.linux@gmail.com>,
linuxppc-dev@lists.ozlabs.org, Sun Jian <sun.jian.kdev@gmail.com>,
kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH v2 0/5] vDSO: Use 32-bit CHECKFLAGS for compat vDSO
Date: Fri, 6 Mar 2026 11:43:24 +0100 [thread overview]
Message-ID: <96cdd223-5139-4535-b82d-831dac472cc3@kernel.org> (raw)
In-Reply-To: <20260302-vdso-compat-checkflags-v2-0-78e55baa58ba@linutronix.de>
Le 02/03/2026 à 08:58, Thomas Weißschuh a écrit :
> When building the compat vDSO the CHECKFLAGS from the 64-bit kernel
> are used. These are combined with the 32-bit CFLAGS. This confuses
> sparse, producing false-positive warnings or potentially missing
> real issues.
>
> Manually override the CHECKFLAGS for the compat vDSO with the correct
> 32-bit configuration.
>
> Not all architectures are supported, as many do not use sparse for their
> (compat) vDSO. These can be enabled later.
>
> Also add some checks to bitsperlong.h to detect such issues earlier.
>
> Based on tip/timers/vdso.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> Changes in v2:
> - Simplify __BITS_PER_LONG consistency checks
> - Fix an inconsistency in the powerpc audit code
The powerpc audit code should be replaced by generic
AUDIT_ARCH_COMPAT_GENERIC, as there is no difference between them
apparently.
A tentative was made in the past but was declined by audit maintainers
because we were not able to test it allthought the failure was the same
before and after the patch, see
https://github.com/linuxppc/issues/issues/412
Christophe
next prev parent reply other threads:[~2026-03-06 10:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 7:58 [PATCH v2 0/5] vDSO: Use 32-bit CHECKFLAGS for compat vDSO Thomas Weißschuh
2026-03-02 7:58 ` [PATCH v2 1/5] x86/vdso: " Thomas Weißschuh
2026-03-02 7:58 ` [PATCH v2 2/5] sparc64: vdso: " Thomas Weißschuh
2026-03-02 7:58 ` [PATCH v2 3/5] s390: Add -m64 to KBUILD_CPPFLAGS Thomas Weißschuh
2026-03-02 8:42 ` Arnd Bergmann
2026-03-02 7:58 ` [PATCH v2 4/5] powerpc/audit: directly include unistd_32.h from compat_audit.c Thomas Weißschuh
2026-03-02 8:41 ` Arnd Bergmann
2026-03-02 7:58 ` [PATCH v2 5/5] asm-generic/bitsperlong.h: Add sanity checks for __BITS_PER_LONG Thomas Weißschuh
2026-03-06 10:43 ` Christophe Leroy (CS GROUP) [this message]
2026-03-06 13:08 ` [PATCH v2 0/5] vDSO: Use 32-bit CHECKFLAGS for compat vDSO Thomas Weißschuh
2026-03-06 13:26 ` Christophe Leroy (CS GROUP)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96cdd223-5139-4535-b82d-831dac472cc3@kernel.org \
--to=chleroy@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=andreas@gaisler.com \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=luto@kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=sun.jian.kdev@gmail.com \
--cc=svens@linux.ibm.com \
--cc=tglx@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox