From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v6 05/10] mm/memory_hotplug: Shrink zones when offlining memory References: <20191006085646.5768-1-david@redhat.com> <20191006085646.5768-6-david@redhat.com> <20191203151030.GB2600@linux> From: David Hildenbrand Message-ID: <9789e892-dd15-c37d-7c0a-0ccb4db1a987@redhat.com> Date: Tue, 3 Dec 2019 16:27:12 +0100 MIME-Version: 1.0 In-Reply-To: <20191203151030.GB2600@linux> Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org List-ID: To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, x86@kernel.org, Andrew Morton , Michal Hocko , "Matthew Wilcox (Oracle)" , "Aneesh Kumar K.V" , Pavel Tatashin , Greg Kroah-Hartman , Dan Williams , Logan Gunthorpe On 03.12.19 16:10, Oscar Salvador wrote: > On Sun, Oct 06, 2019 at 10:56:41AM +0200, David Hildenbrand wrote: >> Fixes: d0dc12e86b31 ("mm/memory_hotplug: optimize memory hotplug") >> Signed-off-by: David Hildenbrand >=20 > I did not see anything wrong with the taken approach, and makes sense to = me. > The only thing that puzzles me is we seem to not balance spanned_pages > for ZONE_DEVICE anymore. > memremap_pages() increments them via move_pfn_range_to_zone, but we skip > ZONE_DEVICE in remove_pfn_range_from_zone. Yes, documented e.g., in commit 7ce700bf11b5e2cb84e4352bbdf2123a7a239c84 Author: David Hildenbrand Date: Thu Nov 21 17:53:56 2019 -0800 mm/memory_hotplug: don't access uninitialized memmaps in shrink_zone_span() Needs some more thought - but is definitely not urgent (well, now it's at least no longer completely broken). >=20 > That is not really related to this patch, so I might be missing something= , > but it caught my eye while reviewing this. >=20 > Anyway, for this one: >=20 > Reviewed-by: Oscar Salvador >=20 Thanks! >=20 > off-topic: I __think__ we really need to trim the CC list. Yes we should :) - done. --=20 Thanks, David / dhildenb