From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:24902 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbfLIQpE (ORCPT ); Mon, 9 Dec 2019 11:45:04 -0500 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xB9GMMO3109006 for ; Mon, 9 Dec 2019 11:45:02 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wrth04bpm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 Dec 2019 11:45:02 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Dec 2019 16:45:00 -0000 Subject: Re: [kvm-unit-tests PATCH v3 3/9] s390: interrupt registration References: <1575649588-6127-1-git-send-email-pmorel@linux.ibm.com> <1575649588-6127-4-git-send-email-pmorel@linux.ibm.com> From: Pierre Morel Date: Mon, 9 Dec 2019 17:44:56 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <997516f1-acda-446c-1359-e0125a306db2@linux.ibm.com> Sender: linux-s390-owner@vger.kernel.org List-ID: To: Thomas Huth , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com On 2019-12-09 12:40, Thomas Huth wrote: > On 06/12/2019 17.26, Pierre Morel wrote: >> Define two functions to register and to unregister a call back for IO >> Interrupt handling. >> >> Per default we keep the old behavior, so does a successful unregister >> of the callback. >> >> Signed-off-by: Pierre Morel >> --- >> lib/s390x/interrupt.c | 23 ++++++++++++++++++++++- >> lib/s390x/interrupt.h | 7 +++++++ >> 2 files changed, 29 insertions(+), 1 deletion(-) >> create mode 100644 lib/s390x/interrupt.h >> >> diff --git a/lib/s390x/interrupt.c b/lib/s390x/interrupt.c >> index 3e07867..e0eae4d 100644 >> --- a/lib/s390x/interrupt.c >> +++ b/lib/s390x/interrupt.c >> @@ -10,9 +10,9 @@ >> * under the terms of the GNU Library General Public License version 2. >> */ >> #include >> -#include >> #include >> #include >> +#include >> >> static bool pgm_int_expected; >> static bool ext_int_expected; >> @@ -140,12 +140,33 @@ void handle_mcck_int(void) >> lc->mcck_old_psw.addr); >> } >> >> +static void (*io_int_func)(void); >> + >> void handle_io_int(void) >> { >> + if (*io_int_func) >> + return (*io_int_func)(); >> + >> report_abort("Unexpected io interrupt: at %#lx", >> lc->io_old_psw.addr); >> } >> >> +int register_io_int_func(void (*f)(void)) >> +{ >> + if (io_int_func) >> + return -1; >> + io_int_func = f; >> + return 0; >> +} >> + >> +int unregister_io_int_func(void (*f)(void)) >> +{ >> + if (io_int_func != f) >> + return -1; >> + io_int_func = NULL; >> + return 0; >> +} >> + >> void handle_svc_int(void) >> { >> report_abort("Unexpected supervisor call interrupt: at %#lx", >> diff --git a/lib/s390x/interrupt.h b/lib/s390x/interrupt.h >> new file mode 100644 >> index 0000000..e945ef7 >> --- /dev/null >> +++ b/lib/s390x/interrupt.h >> @@ -0,0 +1,7 @@ >> +#ifndef __INTERRUPT_H >> +#include >> + >> +int register_io_int_func(void (*f)(void)); >> +int unregister_io_int_func(void (*f)(void)); >> + >> +#endif >> > > Reviewed-by: Thomas Huth > Thanks, Pierre -- Pierre Morel IBM Lab Boeblingen