From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:57723 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727985AbgGBHXU (ORCPT ); Thu, 2 Jul 2020 03:23:20 -0400 Subject: Re: [PATCH v2 1/2] mm/memblock: expose only miminal interface to add/walk physmem References: <20200701141830.18749-1-david@redhat.com> <20200701141830.18749-2-david@redhat.com> <20200701150643.GA2999146@linux.ibm.com> <20200701153157.GC5008@osiris> From: David Hildenbrand Message-ID: <9a6728b2-05d3-0e98-dc45-a3e4821e0539@redhat.com> Date: Thu, 2 Jul 2020 09:23:10 +0200 MIME-Version: 1.0 In-Reply-To: <20200701153157.GC5008@osiris> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Heiko Carstens , Mike Rapoport , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, Vasily Gorbik , Christian Borntraeger On 01.07.20 17:31, Heiko Carstens wrote: > On Wed, Jul 01, 2020 at 06:06:43PM +0300, Mike Rapoport wrote: >> Hi David, >> >> On Wed, Jul 01, 2020 at 04:18:29PM +0200, David Hildenbrand wrote: >>> "physmem" in the memblock allocator is somewhat weird: it's not actually >>> used for allocation, it's simply information collected during boot, which >>> describes the unmodified physical memory map at boot time, without any >>> standby/hotplugged memory. It's only used on s390x and is currently the >>> only reason s390x keeps using CONFIG_ARCH_KEEP_MEMBLOCK. >>> >>> Physmem isn't numa aware and current users don't specify any flags. Let's >>> hide it from the user, exposing only for_each_physmem(), and simplify. The >>> interface for physmem is now really minimalistic: >>> - memblock_physmem_add() to add ranges >>> - for_each_physmem() / __next_physmem_range() to walk physmem ranges >>> >>> Don't place it into an __init section and don't discard it without >>> CONFIG_ARCH_KEEP_MEMBLOCK. As we're reusing __next_mem_range(), remove >>> the __meminit notifier to avoid section mismatch warnings once >>> CONFIG_ARCH_KEEP_MEMBLOCK is no longer used with >>> CONFIG_HAVE_MEMBLOCK_PHYS_MAP. >>> >>> While fixing up the documentation, sneak in some related cleanups. We can >>> stop setting CONFIG_HAVE_MEMBLOCK_PHYS_MAP for s390x next. >> >> As you noted in the previous version it should have been >> CONFIG_ARCH_KEEP_MEMBLOCK ;-) >> >>> Cc: Heiko Carstens >>> Cc: Vasily Gorbik >>> Cc: Christian Borntraeger >>> Cc: Mike Rapoport >>> Cc: Andrew Morton >>> Signed-off-by: David Hildenbrand >> >> Reviewed-by: Mike Rapoport >> >>> --- >>> arch/s390/kernel/crash_dump.c | 6 ++-- >>> include/linux/memblock.h | 28 ++++++++++++++--- >>> mm/memblock.c | 57 ++++++++++++++++++----------------- >>> 3 files changed, 55 insertions(+), 36 deletions(-) > > So I guess this should go via the s390 tree, since the second patch of > this series can go only upstream if both this patch and a patch which > is currently only on our features are merged before. > > Any objections? @Andrew, fine with you if this goes via the s390 tree? -- Thanks, David / dhildenb