From mboxrd@z Thu Jan 1 00:00:00 1970 From: Halil Pasic Subject: Re: [FIXUP v11] fixup! s390: vfio-ap: implement mediated device open callback Date: Fri, 28 Sep 2018 15:41:35 +0200 Message-ID: <9da2f32b-2d58-fcd1-a830-1fba0ed8bc0c@linux.ibm.com> References: <20180928121429.7323d78b.cohuck@redhat.com> <20180928133321.31884-1-akrowiak@linux.vnet.ibm.com> <20180928153506.3521bc33.cohuck@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180928153506.3521bc33.cohuck@redhat.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Cornelia Huck , Tony Krowiak Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com, Tony Krowiak List-ID: On 09/28/2018 03:35 PM, Cornelia Huck wrote: > On Fri, 28 Sep 2018 09:33:21 -0400 > Tony Krowiak wrote: > >> From: Tony Krowiak >> >> Fixes case statement in vfio_ap_mdev_copy_masks() function in >> vfio-ap-ops.c. >> --- >> drivers/s390/crypto/vfio_ap_ops.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c >> index e1e1beaaeba5..86b42487a51c 100644 >> --- a/drivers/s390/crypto/vfio_ap_ops.c >> +++ b/drivers/s390/crypto/vfio_ap_ops.c >> @@ -741,11 +741,12 @@ static void vfio_ap_mdev_copy_masks(struct ap_matrix_mdev *matrix_mdev) >> break; >> case CRYCB_FORMAT1: >> case CRYCB_FORMAT0: >> - default: >> apm = (unsigned long *)crycb->apcb0.apm; >> aqm = (unsigned long *)crycb->apcb0.aqm; >> adm = (unsigned long *)crycb->apcb0.adm; >> break; >> + default: >> + return; > > /* cannot happen */ > > ? Or use something like BUG(). Without conveying that default is illegal we don't gain anything over the previous version IMHO. > >> } >> >> nbytes = DIV_ROUND_UP(matrix_mdev->matrix.apm_max + 1, BITS_PER_BYTE); >