From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbgLBWgb (ORCPT ); Wed, 2 Dec 2020 17:36:31 -0500 Sender: Tejun Heo Date: Wed, 2 Dec 2020 17:35:21 -0500 From: Tejun Heo Subject: Re: store a pointer to the block_device in struct bio (again) Message-ID: References: <20201201165424.2030647-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201201165424.2030647-1-hch@lst.de> List-ID: To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Song Liu , dm-devel@redhat.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-block@vger.kernel.org On Tue, Dec 01, 2020 at 05:54:15PM +0100, Christoph Hellwig wrote: > Hi Jens, > > this series switches back from storing the gendisk + partno to storing > a block_device pointer in struct bio. The reason is two fold: for one > the new struct block_device actually is always available, removing the > need to avoid originally. Second the merge struct block_device is much > more useful than the old one, as storing it avoids the need for looking > up what used to be hd_struct during partition remapping and I/O > accounting. > > Note that this series depends on the posted but not merged > "block tracepoint cleanups" series. I'm late but everything looks good to me. So much better than the mess we had before. Thank you. The only thing I noticed is that blkdev_get_no_open() can now use kobject_get() instead of kobject_get_unless_zero() as bdev lookup is synchronously disabled before device_del(). -- tejun