From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4926C64ED6 for ; Tue, 28 Feb 2023 08:58:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229978AbjB1I6Z (ORCPT ); Tue, 28 Feb 2023 03:58:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230059AbjB1I6V (ORCPT ); Tue, 28 Feb 2023 03:58:21 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACFD57D9F; Tue, 28 Feb 2023 00:58:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E33761030; Tue, 28 Feb 2023 08:58:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24246C433D2; Tue, 28 Feb 2023 08:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1677574699; bh=UztsLsaqmIXyoCT63yUOOYX/F2RBn+tEboh82iUTl84=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dvFldP2nDPK1JM1UdTSvrNFQgLKdCKwOzfkHHphaxtZJbfiOb+x1w8SgrPHVVLpTM 0+DGxsyLVGr/st2iaB5VqG6eeN9RmbwrKyu1S1M0ogYouEhMNuHsdIhPyL2tnEfVU1 gTZGjIJffgoh26CK72V24tXXKN+/RvSZ3yTVgjyc= Date: Tue, 28 Feb 2023 09:58:16 +0100 From: Greg Kroah-Hartman To: Tom Saeger Cc: Sasha Levin , Naresh Kamboju , John Paul Adrian Glaubitz , Rich Felker , Masahiro Yamada , Ard Biesheuvel , Nathan Chancellor , Dennis Gilmore , Palmer Dabbelt , Arnd Bergmann , Andrew Morton , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH 5.15 v2 1/5] arch: fix broken BuildID for arm64 and riscv Message-ID: References: <20230210-tsaeger-upstream-linux-stable-5-15-v2-0-6c68622745e9@oracle.com> <20230210-tsaeger-upstream-linux-stable-5-15-v2-1-6c68622745e9@oracle.com> <20230223175331.7tsgvkvcur6wl7h7@oracle.com> <20230224024724.whvtsrljz5k3jpln@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230224024724.whvtsrljz5k3jpln@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Thu, Feb 23, 2023 at 08:47:24PM -0600, Tom Saeger wrote: > On Thu, Feb 23, 2023 at 11:53:42AM -0600, Tom Saeger wrote: > > On Thu, Feb 23, 2023 at 10:51:45AM +0100, Greg Kroah-Hartman wrote: > > > On Fri, Feb 10, 2023 at 01:18:40PM -0700, Tom Saeger wrote: > > > > From: Masahiro Yamada > > > > > > > > commit 99cb0d917ffa1ab628bb67364ca9b162c07699b1 upstream. > > > > > > > > Dennis Gilmore reports that the BuildID is missing in the arm64 vmlinux > > > > since commit 994b7ac1697b ("arm64: remove special treatment for the > > > > link order of head.o"). > > > > > > > > The issue is that the type of .notes section, which contains the BuildID, > > > > changed from NOTES to PROGBITS. > > > > > > > > Ard Biesheuvel figured out that whichever object gets linked first gets > > > > to decide the type of a section. The PROGBITS type is the result of the > > > > compiler emitting .note.GNU-stack as PROGBITS rather than NOTE. > > > > > > > > While Ard provided a fix for arm64, I want to fix this globally because > > > > the same issue is happening on riscv since commit 2348e6bf4421 ("riscv: > > > > remove special treatment for the link order of head.o"). This problem > > > > will happen in general for other architectures if they start to drop > > > > unneeded entries from scripts/head-object-list.txt. > > > > > > > > Discard .note.GNU-stack in include/asm-generic/vmlinux.lds.h. > > > > > > > > Link: https://lore.kernel.org/lkml/CAABkxwuQoz1CTbyb57n0ZX65eSYiTonFCU8-LCQc=74D=xE=rA@mail.gmail.com/ > > > > Fixes: 994b7ac1697b ("arm64: remove special treatment for the link order of head.o") > > > > Fixes: 2348e6bf4421 ("riscv: remove special treatment for the link order of head.o") > > Greg, how about something like this tacked onto backport of this commit? > > [Tom: stable backport 5.15.y, 5.10.y, 5.4.y] > > Though the above "Fixes:" commits are not in this kernel, the conditions > which lead to a missing Build ID in arm64 vmlinux are similar. > > Evidence points to these conditions: > 1. ld version > 2.36 (exact binutils commit documented in a494398bde27) > 2. first object which gets linked (head.o) has a PROGBITS .note.GNU-stack segment > > These conditions can be observed when: > - 5.15.60+ OR 5.10.136+ OR 5.4.210+ > - AND ld version > 2.36 > - AND arch=arm64 > - AND CONFIG_MODVERSIONS=y > > This was previously bisected to the stable backport of 0d362be5b142. > Follow-up experiments were discussed here: https://lore.kernel.org/all/20221221235413.xaisboqmr7dkqwn6@oracle.com/ > which strongly hints at condition 2. > > > > > > > > Why are we adding a commit to 5.15.y that fixes an issue that only > > > showed up in 6.1.y? > > If you approve - I'll send v3 for 5.15, 5.10, and 5.4 (with style fixes). That would make more sense, thanks. greg k-h