From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDF4DC64ED6 for ; Wed, 1 Mar 2023 15:11:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229981AbjCAPLn (ORCPT ); Wed, 1 Mar 2023 10:11:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229563AbjCAPLm (ORCPT ); Wed, 1 Mar 2023 10:11:42 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C0F016897; Wed, 1 Mar 2023 07:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677683501; x=1709219501; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hjYr2EMRWWOBA1w4cnhzIu+T7tZBlHG4CpSb2cRhb34=; b=NJpRKkRpt3/rHgSTAxW7Cfe4xrLcj7xTxAaVhCl+QmzqeJ5VQ/gmDrtV vjGoQOpwZX0URqFhPruGS4A6Mu7caXc2SUlxT70+8zkgapsFYwO8RA4vr T8v792GxcXnPD23LoB4vF+bypJ/V6oZgZbqLU4rG5cVpKnxwUR8xAEhb1 m26mL2tuLf2+hRWy5eb6LNhNtD69PMgbDs5moQFUapjgtF8dPG1Gpak4R gYf1MO1azj7m8mfidv34qc5gBhRw/lQ0IiITib7wceTFG9H8zQSAN+93d 2cQatQGshVtoxvU7TYtHn8KYm6oa0JgiX3PsfngWN93AtRxXP16xtBtDK A==; X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="318230725" X-IronPort-AV: E=Sophos;i="5.98,225,1673942400"; d="scan'208";a="318230725" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2023 07:11:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="920278181" X-IronPort-AV: E=Sophos;i="5.98,225,1673942400"; d="scan'208";a="920278181" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 01 Mar 2023 07:11:34 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pXO7B-00Dnz1-0F; Wed, 01 Mar 2023 17:11:33 +0200 Date: Wed, 1 Mar 2023 17:11:32 +0200 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Alexander Lobakin , Christian Borntraeger , Claudio Imbrenda , David Hildenbrand , Guenter Roeck , Heiko Carstens , Janosch Frank , Rasmus Villemoes , Sven Schnelle , Vasily Gorbik , linux-s390@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 1/2] lib/test_bitmap: increment failure counter properly Message-ID: References: <20230227214524.914050-1-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Mon, Feb 27, 2023 at 06:49:29PM -0800, Yury Norov wrote: > On Tue, Feb 28, 2023 at 12:55:05AM +0200, Andy Shevchenko wrote: > > On Mon, Feb 27, 2023 at 01:45:23PM -0800, Yury Norov wrote: > > > The tests that don't use expect_eq() macro to determine that a test is > > > failured must increment failed_tests explicitly. > > > > ... > > > > > pr_err("bitmap_copy_arr32(nbits == %d:" > > > " tail is not safely cleared: %d\n", > > > > Usually we don't split string literals (since checkpatch doesn't complain on a > > looong lines with them at the end of the line), > > > > ... > > > > > pr_err("bitmap_copy_arr64(nbits == %d:" > > > " tail is not safely cleared: %d\n", nbits, next_bit); > > > > Ditto. > > > > P.S. Seems a material for another patch. > > If you're OK with this patch, can you give your review tag please? I'm fine with the series, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko