Re: [PATCH v7 2/6] iommu/s390: Get rid of s390_domain_device

Jason Gunthorpe
2022-10-24T18:43:52Z

On Mon, Oct 17, 2022 at 02:45:54PM +0200, Niklas Schnelle wrote:
> The struct s390_domain_device serves the sole purpose as list entry for
> the devices list of a struct s390_domain. As it contains no additional
> information besides a list_head and a pointer to the struct zpci_dev we
> can simplify things and just thread the device list through struct
> zpci_dev directly. This removes the need to allocate during domain
> attach and gets rid of one level of indirection during mapping
> operations.
>
> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
> v5->v6:
> - On attach failure make sure the IOAT is not registered
> and zdev->dma_table == NULL
> - Dropped Jason's R-b

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason