Re: [PATCH] net/smc: loop in smc_listen

Tony Lu
2021-11-22T08:37:49Z

On Sat, Nov 20, 2021 at 03:54:51PM +0800, Daxing Guo wrote:
> From: Guo DaXing <guodaxing@huawei.com>
>
> The kernel_listen function in smc_listen will fail when all the available
> ports are occupied. At this point smc->clcsock->sk->sk_data_ready has
> been changed to smc_clcsock_data_ready. When we call smc_listen again,
> now both smc->clcsock->sk->sk_data_ready and smc->clcsk_data_ready point
> to the smc_clcsock_data_ready function.
>
> The smc_clcsock_data_ready() function calls lsmc->clcsk_data_ready which
> now points to itself resulting in an infinite loop.
>
> This patch restores smc->clcsock->sk->sk_data_ready with the old value.
>
> Signed-off-by: Guo DaXing <guodaxing@huawei.com>

It works in my testing environment, thanks.

Acked-by: Tony Lu <tonylu@linux.alibaba.com>