From: Heiko Carstens <hca@linux.ibm.com>
To: cgel.zte@gmail.com
Cc: oleg@redhat.com, gor@linux.ibm.com, borntraeger@linux.ibm.com,
agordeev@linux.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org,
Minghao Chi <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] arch/s390/kernel: remove unneeded rc variable
Date: Tue, 18 Jan 2022 10:15:30 +0100 [thread overview]
Message-ID: <YeaFMspieut8Y6tJ@osiris> (raw)
In-Reply-To: <20220118075115.925468-1-chi.minghao@zte.com.cn>
On Tue, Jan 18, 2022 at 07:51:15AM +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from user_regset_copyin() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> ---
> arch/s390/kernel/ptrace.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
...
> - int rc;
> -
> if (!MACHINE_HAS_VX)
> return -ENODEV;
> if (target == current)
> save_fpu_regs();
>
> - rc = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
> + return user_regset_copyin(&pos, &count, &kbuf, &ubuf,
> target->thread.fpu.vxrs + __NUM_VXRS_LOW, 0, -1);
> - return rc;
This "breaks" indentation. Could you guys please stop sending such
semi-automated generated questionable patches? I really don't see any
benefit besides code churn, and the possibility of introducing bugs.
Thanks!
prev parent reply other threads:[~2022-01-18 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 7:51 [PATCH] arch/s390/kernel: remove unneeded rc variable cgel.zte
2022-01-18 9:15 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeaFMspieut8Y6tJ@osiris \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).